From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Paasch <cpaasch@apple.com>
Subject: Re: [PATCH net] tcp: Always cleanup skb before sending
Date: Thu, 02 Nov 2017 11:16:58 -0700
Message-ID: <20171102181658.GU44287@da0602a-dhcp105.apple.com>
References: <20171101211001.57901-1-cpaasch@apple.com>
 <CANn89iLv+0+A79-pNu8HZ2kBbyNt2ini2Zjbm++s9TT7mtOamw@mail.gmail.com>
 <1509573218.3828.54.camel@edumazet-glaptop3.roam.corp.google.com>
 <20171102001035.GR44287@da0602a-dhcp105.apple.com>
 <1509584410.3828.64.camel@edumazet-glaptop3.roam.corp.google.com>
Mime-Version: 1.0
Content-Type: text/plain; CHARSET=US-ASCII
Content-Transfer-Encoding: 7BIT
Cc: Eric Dumazet <edumazet@google.com>,
        David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-out6.apple.com ([17.151.62.28]:64198 "EHLO
        mail-in6.apple.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S933623AbdKBSQ6 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 2 Nov 2017 14:16:58 -0400
Content-disposition: inline
In-reply-to: <1509584410.3828.64.camel@edumazet-glaptop3.roam.corp.google.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 01/11/17 - 18:00:10, Eric Dumazet wrote:
> On Wed, 2017-11-01 at 17:10 -0700, Christoph Paasch wrote:
> 
> > Yes, that looks good to me. Thanks!
> > 
> > But we still need to clean up the skb in tcp_v4_send_reset and
> > tcp_v4_send_ack, as the fields (e.g., tcp_skb_cb->seq) have been set when
> > coming from tcp_v4_rcv.
> 
> You might be confused : ip_send_unicast_reply() does not send back the
> incoming skb.
> 
> A fresh skb is allocated, then appended/sent.
> 
> And commit 24a2d43d8886f5a29c did the changes to provide to
> __ip_options_echo() the proper IPCB header location.

Yes, sorry I misunderstood ip_send_unicast_reply(). Didn't see the
allocation of the new skb.


Christoph