From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, dave.taht@gmail.com, jiri@mellanox.com
Subject: Re: [Patch net-next] net_sched: check NULL in tcf_block_put()
Date: Fri, 03 Nov 2017 21:31:32 +0900 (KST) [thread overview]
Message-ID: <20171103.213132.1713032886433577331.davem@davemloft.net> (raw)
In-Reply-To: <20171103003208.12329-1-xiyou.wangcong@gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Thu, 2 Nov 2017 17:32:08 -0700
> Callers of tcf_block_put() could pass NULL so
> we can't use block->q before checking if block is
> NULL or not.
>
> tcf_block_put_ext() callers are fine, it is always
> non-NULL.
>
> Fixes: 8c4083b30e56 ("net: sched: add block bind/unbind notif. and extended block_get/put")
> Reported-by: Dave Taht <dave.taht@gmail.com>
> Cc: Jiri Pirko <jiri@mellanox.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Applied, thanks Cong.
prev parent reply other threads:[~2017-11-03 12:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 0:32 [Patch net-next] net_sched: check NULL in tcf_block_put() Cong Wang
2017-11-03 6:56 ` Jiri Pirko
2017-11-03 12:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103.213132.1713032886433577331.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dave.taht@gmail.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.