Re: [PATCH v3 2/3] KVM: add converters between pfn_t and kvm_pfn_t

From: Haozhong Zhang <haozhong.zhang@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: KVM list <kvm@vger.kernel.org>, X86 ML <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	rkrcmar@redhat.com, Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
	"Cuevas Escareno, Ivan D" <ivan.d.cuevas.escareno@intel.com>,
	"Kumar, Karthik" <karthik.kumar@intel.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Olif Chapman <olif.chapman@oracle.com>
Subject: Re: [PATCH v3 2/3] KVM: add converters between pfn_t and kvm_pfn_t
Date: Fri, 3 Nov 2017 10:39:12 +0800	[thread overview]
Message-ID: <20171103023912.gsa6dvwtozgi5fmj@hz-desktop> (raw)
In-Reply-To: <CAPcyv4iPLU5apAsMq2gqh-8hsWdGdkYodirnr5dwaRJ_qEP-SA@mail.gmail.com>

On 11/02/17 19:25 -0700, Dan Williams wrote:
> On Thu, Nov 2, 2017 at 6:16 PM, Haozhong Zhang <haozhong.zhang@intel.com> wrote:
> > Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
> > ---
> >  include/linux/kvm_host.h | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> > index 6882538eda32..759fe498c89e 100644
> > --- a/include/linux/kvm_host.h
> > +++ b/include/linux/kvm_host.h
> > @@ -67,6 +67,9 @@
> >  #define KVM_PFN_ERR_HWPOISON   (KVM_PFN_ERR_MASK + 1)
> >  #define KVM_PFN_ERR_RO_FAULT   (KVM_PFN_ERR_MASK + 2)
> >
> > +#define kvm_pfn_to_pfn(x) ((pfn_t){ .val = (x)})
> > +#define pfn_to_kvm_pfn(x) ((kvm_pfn_t)((x).val))
> 
> Shouldn't this mask off the kvm_pfn_t and  pfn_t specific bits when
> converting between the two?

Yes, I'll fix it.

Thanks,
Haozhong