From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAaaX-0005sF-Uz for qemu-devel@nongnu.org; Fri, 03 Nov 2017 07:56:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAaaT-0003Wv-La for qemu-devel@nongnu.org; Fri, 03 Nov 2017 07:56:42 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:36064) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eAaaT-0003VK-GB for qemu-devel@nongnu.org; Fri, 03 Nov 2017 07:56:37 -0400 From: Owen Smith Date: Fri, 3 Nov 2017 11:56:31 +0000 Message-ID: <20171103115631.15175-5-owen.smith@citrix.com> In-Reply-To: <20171103115631.15175-1-owen.smith@citrix.com> References: <20171103115631.15175-1-owen.smith@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v5 4/4] xenfb: activate input handlers for raw pointer devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sstabellini@kernel.org, anthony.perard@citrix.com, kraxel@redhat.com Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, owen.smith@citrix.com If the frontend requests raw pointers, the input handlers must be activated to have the input events delivered to the xenfb backend. Without activation, the input events are delivered to handlers registered earlier, which would be the emulated USB tablet or emulated PS/2 mouse. HVM xen_kbdfront can incorrectly scale absolute coordinates when the display resolution is not 800x600. Signed-off-by: Owen Smith --- hw/display/xenfb.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index 3cbc248c34..c070c84f5b 100644 --- a/hw/display/xenfb.c +++ b/hw/display/xenfb.c @@ -387,6 +387,11 @@ static void input_connected(struct XenDevice *xendev) in->qkbd = qemu_input_handler_register((DeviceState *)in, &xenfb_keyboard); in->qmou = qemu_input_handler_register((DeviceState *)in, in->abs_pointer_wanted ? &xenfb_abs_mouse : &xenfb_rel_mouse); + + if (in->raw_pointer_wanted) { + qemu_input_handler_activate(in->qkbd); + qemu_input_handler_activate(in->qmou); + } } static void input_disconnect(struct XenDevice *xendev) -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Owen Smith Subject: [PATCH v5 4/4] xenfb: activate input handlers for raw pointer devices Date: Fri, 3 Nov 2017 11:56:31 +0000 Message-ID: <20171103115631.15175-5-owen.smith@citrix.com> References: <20171103115631.15175-1-owen.smith@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAaaW-0008Cb-7r for xen-devel@lists.xenproject.org; Fri, 03 Nov 2017 11:56:40 +0000 In-Reply-To: <20171103115631.15175-1-owen.smith@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: sstabellini@kernel.org, anthony.perard@citrix.com, kraxel@redhat.com Cc: xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, owen.smith@citrix.com List-Id: xen-devel@lists.xenproject.org SWYgdGhlIGZyb250ZW5kIHJlcXVlc3RzIHJhdyBwb2ludGVycywgdGhlIGlucHV0IGhhbmRsZXJz IG11c3QgYmUKYWN0aXZhdGVkIHRvIGhhdmUgdGhlIGlucHV0IGV2ZW50cyBkZWxpdmVyZWQgdG8g dGhlIHhlbmZiIGJhY2tlbmQuCldpdGhvdXQgYWN0aXZhdGlvbiwgdGhlIGlucHV0IGV2ZW50cyBh cmUgZGVsaXZlcmVkIHRvIGhhbmRsZXJzCnJlZ2lzdGVyZWQgZWFybGllciwgd2hpY2ggd291bGQg YmUgdGhlIGVtdWxhdGVkIFVTQiB0YWJsZXQgb3IKZW11bGF0ZWQgUFMvMiBtb3VzZS4KSFZNIHhl bl9rYmRmcm9udCBjYW4gaW5jb3JyZWN0bHkgc2NhbGUgYWJzb2x1dGUgY29vcmRpbmF0ZXMgd2hl bgp0aGUgZGlzcGxheSByZXNvbHV0aW9uIGlzIG5vdCA4MDB4NjAwLgoKU2lnbmVkLW9mZi1ieTog T3dlbiBTbWl0aCA8b3dlbi5zbWl0aEBjaXRyaXguY29tPgotLS0KIGh3L2Rpc3BsYXkveGVuZmIu YyB8IDUgKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQg YS9ody9kaXNwbGF5L3hlbmZiLmMgYi9ody9kaXNwbGF5L3hlbmZiLmMKaW5kZXggM2NiYzI0OGMz NC4uYzA3MGM4NGY1YiAxMDA2NDQKLS0tIGEvaHcvZGlzcGxheS94ZW5mYi5jCisrKyBiL2h3L2Rp c3BsYXkveGVuZmIuYwpAQCAtMzg3LDYgKzM4NywxMSBAQCBzdGF0aWMgdm9pZCBpbnB1dF9jb25u ZWN0ZWQoc3RydWN0IFhlbkRldmljZSAqeGVuZGV2KQogICAgIGluLT5xa2JkID0gcWVtdV9pbnB1 dF9oYW5kbGVyX3JlZ2lzdGVyKChEZXZpY2VTdGF0ZSAqKWluLCAmeGVuZmJfa2V5Ym9hcmQpOwog ICAgIGluLT5xbW91ID0gcWVtdV9pbnB1dF9oYW5kbGVyX3JlZ2lzdGVyKChEZXZpY2VTdGF0ZSAq KWluLAogICAgICAgICAgICAgICAgaW4tPmFic19wb2ludGVyX3dhbnRlZCA/ICZ4ZW5mYl9hYnNf bW91c2UgOiAmeGVuZmJfcmVsX21vdXNlKTsKKworICAgIGlmIChpbi0+cmF3X3BvaW50ZXJfd2Fu dGVkKSB7CisgICAgICAgIHFlbXVfaW5wdXRfaGFuZGxlcl9hY3RpdmF0ZShpbi0+cWtiZCk7Cisg ICAgICAgIHFlbXVfaW5wdXRfaGFuZGxlcl9hY3RpdmF0ZShpbi0+cW1vdSk7CisgICAgfQogfQog CiBzdGF0aWMgdm9pZCBpbnB1dF9kaXNjb25uZWN0KHN0cnVjdCBYZW5EZXZpY2UgKnhlbmRldikK LS0gCjIuMTEuMAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6 Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=