From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756106AbdKCMF4 (ORCPT ); Fri, 3 Nov 2017 08:05:56 -0400 Received: from mail.skyhub.de ([5.9.137.197]:37704 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753022AbdKCMFz (ORCPT ); Fri, 3 Nov 2017 08:05:55 -0400 Date: Fri, 3 Nov 2017 13:05:46 +0100 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/mce/AMD: Fix mce_severity_amd_smca() signature Message-ID: <20171103120546.xy2r5ulmk7us5tfi@pd.tnic> References: <1509563052-10039-1-git-send-email-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1509563052-10039-1-git-send-email-Yazen.Ghannam@amd.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 01, 2017 at 02:04:12PM -0500, Yazen Ghannam wrote: > From: Yazen Ghannam > > Change the err_ctx type to "enum context" to match the type passed in. > > Suggested-by: Borislav Petkov > Signed-off-by: Yazen Ghannam > --- > arch/x86/kernel/cpu/mcheck/mce-severity.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/mce-severity.c b/arch/x86/kernel/cpu/mcheck/mce-severity.c > index f5518706baa6..267311a7fc60 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce-severity.c > +++ b/arch/x86/kernel/cpu/mcheck/mce-severity.c > @@ -204,7 +204,7 @@ static int error_context(struct mce *m) > return IN_KERNEL; > } > > -static int mce_severity_amd_smca(struct mce *m, int err_ctx) > +static int mce_severity_amd_smca(struct mce *m, enum context err_ctx) > { > u32 addr = MSR_AMD64_SMCA_MCx_CONFIG(m->bank); > u32 low, high; > -- Applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: x86/mce/AMD: Fix mce_severity_amd_smca() signature From: Borislav Petkov Message-Id: <20171103120546.xy2r5ulmk7us5tfi@pd.tnic> Date: Fri, 3 Nov 2017 13:05:46 +0100 To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org List-ID: T24gV2VkLCBOb3YgMDEsIDIwMTcgYXQgMDI6MDQ6MTJQTSAtMDUwMCwgWWF6ZW4gR2hhbm5hbSB3 cm90ZToKPiBGcm9tOiBZYXplbiBHaGFubmFtIDx5YXplbi5naGFubmFtQGFtZC5jb20+Cj4gCj4g Q2hhbmdlIHRoZSBlcnJfY3R4IHR5cGUgdG8gImVudW0gY29udGV4dCIgdG8gbWF0Y2ggdGhlIHR5 cGUgcGFzc2VkIGluLgo+IAo+IFN1Z2dlc3RlZC1ieTogQm9yaXNsYXYgUGV0a292IDxicEBzdXNl LmRlPgo+IFNpZ25lZC1vZmYtYnk6IFlhemVuIEdoYW5uYW0gPHlhemVuLmdoYW5uYW1AYW1kLmNv bT4KPiAtLS0KPiAgYXJjaC94ODYva2VybmVsL2NwdS9tY2hlY2svbWNlLXNldmVyaXR5LmMgfCAy ICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+IAo+ IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni9rZXJuZWwvY3B1L21jaGVjay9tY2Utc2V2ZXJpdHkuYyBi L2FyY2gveDg2L2tlcm5lbC9jcHUvbWNoZWNrL21jZS1zZXZlcml0eS5jCj4gaW5kZXggZjU1MTg3 MDZiYWE2Li4yNjczMTFhN2ZjNjAgMTAwNjQ0Cj4gLS0tIGEvYXJjaC94ODYva2VybmVsL2NwdS9t Y2hlY2svbWNlLXNldmVyaXR5LmMKPiArKysgYi9hcmNoL3g4Ni9rZXJuZWwvY3B1L21jaGVjay9t Y2Utc2V2ZXJpdHkuYwo+IEBAIC0yMDQsNyArMjA0LDcgQEAgc3RhdGljIGludCBlcnJvcl9jb250 ZXh0KHN0cnVjdCBtY2UgKm0pCj4gIAlyZXR1cm4gSU5fS0VSTkVMOwo+ICB9Cj4gIAo+IC1zdGF0 aWMgaW50IG1jZV9zZXZlcml0eV9hbWRfc21jYShzdHJ1Y3QgbWNlICptLCBpbnQgZXJyX2N0eCkK PiArc3RhdGljIGludCBtY2Vfc2V2ZXJpdHlfYW1kX3NtY2Eoc3RydWN0IG1jZSAqbSwgZW51bSBj b250ZXh0IGVycl9jdHgpCj4gIHsKPiAgCXUzMiBhZGRyID0gTVNSX0FNRDY0X1NNQ0FfTUN4X0NP TkZJRyhtLT5iYW5rKTsKPiAgCXUzMiBsb3csIGhpZ2g7Cj4gLS0gCgpBcHBsaWVkLCB0aGFua3Mu Cg==