From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751454AbdKDCew (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Nov 2017 22:34:52 -0400
Received: from mga07.intel.com ([134.134.136.100]:52705 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751216AbdKDCev (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Nov 2017 22:34:51 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,339,1505804400"; 
   d="scan'208";a="1239585910"
Date: Fri, 3 Nov 2017 19:28:07 -0700
From: Ramesh Thomas <ramesh.thomas@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux PM <linux-pm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Tero Kristo <t-kristo@ti.com>, Alex Shi <alex.shi@linaro.org>
Subject: Re: [RFT][PATCH v2 2/2] PM / QoS: Fix device resume latency framework
Message-ID: <20171104022806.GA29203@intel.com>
Reply-To: ramesh.thomas@intel.com
References: <5770848.Kdi5IjVKeE@aspire.rjw.lan>
 <2520927.XkLgALY3I0@aspire.rjw.lan>
 <36826935.bDl2WuZxgq@aspire.rjw.lan>
 <aea02edb-b112-18db-6de5-f10e9a43846d@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aea02edb-b112-18db-6de5-f10e9a43846d@intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2017-11-03 at 09:39:08 -0700, Reinette Chatre wrote:
> Hi Rafael,
> 
> I started to test this but found myself triggering one of the warnings:
> 
> On 11/3/2017 4:50 AM, Rafael J. Wysocki wrote:
> > --- linux-pm.orig/include/linux/pm_qos.h
> > +++ linux-pm/include/linux/pm_qos.h
> > @@ -28,16 +28,19 @@ enum pm_qos_flags_status {
> >  	PM_QOS_FLAGS_ALL,
> >  };
> >  
> > -#define PM_QOS_DEFAULT_VALUE -1
> > +#define PM_QOS_DEFAULT_VALUE	(-1)
> 
> PM_QOS_DEFAULT_VALUE is -1 ...
> 
> 
> > ===================================================================
> > --- linux-pm.orig/drivers/base/power/qos.c
> > +++ linux-pm/drivers/base/power/qos.c
> > @@ -139,6 +139,9 @@ static int apply_constraint(struct dev_p
> >  
> >  	switch(req->type) {
> >  	case DEV_PM_QOS_RESUME_LATENCY:
> > +		if (WARN_ON(value < 0))
> > +			value = 0;
> > +
> 
> ... causing me to hit this WARN_ON because apply_constraint() is called by __dev_pm_qos_remove_request() with the value parameter set to PM_QOS_DEFAULT_VALUE.

That value does not get used if action is PM_QOS_REMOVE_REQ. May be just pass
0 or PM_QOS_RESUME_LATENCY_DEFAULT_VALUE everywhere apply_constraint is called
with PM_QOS_REMOVE_REQ action.