From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756175AbdKCU6H (ORCPT ); Fri, 3 Nov 2017 16:58:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:55100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756069AbdKCU6F (ORCPT ); Fri, 3 Nov 2017 16:58:05 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9229F218D2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org Date: Sat, 4 Nov 2017 05:58:02 +0900 From: Masami Hiramatsu To: Arnd Bergmann Cc: Steven Rostedt , Ingo Molnar , Masami Hiramatsu , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: make PREEMPTIRQ_EVENTS depend on TRACING Message-Id: <20171104055802.ce04eeab4849b09bc8c0295e@kernel.org> In-Reply-To: <20171103104031.270375-1-arnd@arndb.de> References: <20171103104031.270375-1-arnd@arndb.de> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 3 Nov 2017 11:39:57 +0100 Arnd Bergmann wrote: > When CONFIG_TRACING is disabled, the new preemptirq events tracer > produces a build failure: > > In file included from kernel/trace/trace_irqsoff.c:17:0: > kernel/trace/trace.h: In function 'trace_test_and_set_recursion': > kernel/trace/trace.h:542:28: error: 'struct task_struct' has no member named 'trace_recursion' > > Adding an explicit dependency avoids the broken configuration. > > Fixes: d59158162e03 ("tracing: Add support for preempt and irq enable/disable events") > Signed-off-by: Arnd Bergmann > --- > No idea if this is the best solution, it just happened to fix the build > failure for me. OK, as same as other tracers, it should select GENERIC_TRACER and TRACER_MAX_TRACE, and depends on TRACE_IRQFLAGS_SUPPORT, and maybe depends on !ARCH_USES_GETTIMEOFFSET. Thank you, > --- > kernel/trace/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > index 1ff10ca078d6..c8c18c793c86 100644 > --- a/kernel/trace/Kconfig > +++ b/kernel/trace/Kconfig > @@ -164,6 +164,7 @@ config PREEMPTIRQ_EVENTS > bool "Enable trace events for preempt and irq disable/enable" > select TRACE_IRQFLAGS > depends on DEBUG_PREEMPT || !PROVE_LOCKING > + depends on TRACING > default n > help > Enable tracing of disable and enable events for preemption and irqs. > -- > 2.9.0 > -- Masami Hiramatsu