From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
Quentin Monnet <quentin.monnet@netronome.com>
Subject: Re: [PATCH net-next] tools: bpftool: move p_err() and p_info() from main.h to common.c
Date: Sat, 4 Nov 2017 18:46:10 +0900 [thread overview]
Message-ID: <20171104094607.q6jigobmd4msm52g@ast-mbp> (raw)
In-Reply-To: <20171103205907.23281-1-jakub.kicinski@netronome.com>
On Fri, Nov 03, 2017 at 01:59:07PM -0700, Jakub Kicinski wrote:
> From: Quentin Monnet <quentin.monnet@netronome.com>
>
> The two functions were declared as static inline in a header file. There
> is no particular reason why they should be inlined, they just happened to
> remain in the same header file when they were turned from macros to
> functions in a precious commit.
>
> Make them non-inlined functions and move them to common.c file instead.
>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
next prev parent reply other threads:[~2017-11-04 9:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 20:59 [PATCH net-next] tools: bpftool: move p_err() and p_info() from main.h to common.c Jakub Kicinski
2017-11-04 9:46 ` Alexei Starovoitov [this message]
2017-11-05 13:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171104094607.q6jigobmd4msm52g@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=quentin.monnet@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.