From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756591AbdKDK3O (ORCPT ); Sat, 4 Nov 2017 06:29:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33888 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751987AbdKDK3M (ORCPT ); Sat, 4 Nov 2017 06:29:12 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7E490883A2 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Sat, 4 Nov 2017 11:29:08 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , Ingo Molnar , Namhyung Kim , David Ahern , Peter Zijlstra , Andi Kleen Subject: Re: [PATCH 00/35] perf annotate: Use generic annotation line Message-ID: <20171104102908.GB7511@krava> References: <20171011150158.11895-1-jolsa@kernel.org> <20171102121632.GA2345@krava> <20171103165901.GG3531@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171103165901.GG3531@kernel.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Sat, 04 Nov 2017 10:29:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 03, 2017 at 01:59:01PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Nov 02, 2017 at 01:16:32PM +0100, Jiri Olsa escreveu: > > On Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa wrote: > > > hi, > > > I'm working on script profiling support and came up > > > with some generic annotation code changes, which IMO > > > make the code simpler and more generic. > > > > > > The main idea of this patchset is to have generic > > > struct (annotation_line), which holds the common > > > profile data. Having this we can easily add new > > > types, like script annotation support. Currently > > > there's disasm_line support only. > > > > > > It's also available at: > > > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/annotate > > > > updated with last perf/core and pushed out > > Can you please ellaborate, write _why_ you're doing these things instead > of just saying _what_ is being done? I will.. guess I worked too long and got too familiar with that, so it did not occur to me there's explanation needed ;-) > > Author: Jiri Olsa > Date: Thu Sep 28 23:13:38 2017 +0200 > > perf annotate browser: Change selection to struct annotation_line > > Use struct annotation_line as a browser::selection. > > Link: http://lkml.kernel.org/n/tip-hq5alvt759wne4pd1doj2ix7@git.kernel.org > Signed-off-by: Jiri Olsa the idea is to move to generic annotation_line struct in generic places so it can work over different sources > > commit 902e9181b8f3807a4e51b587c3e5dcd32d61d3b2 > Author: Jiri Olsa > Date: Tue Oct 3 15:51:43 2017 +0200 > > perf annotate browser: Rename disasm_line__browser to browser_line > > Renaming disasm_line__browser function to browser_line. > > Link: http://lkml.kernel.org/n/tip-xsq9ptt57hc26fytdfnvyoaz@git.kernel.org > Signed-off-by: Jiri Olsa > > commit f75c5dcbb250af16621cf0d4d42efa2ba08641cf > Author: Jiri Olsa > Date: Tue Oct 3 15:48:39 2017 +0200 > > perf annotate browser: Rename struct browser_disasm_line to browser_line > > Renaming struct browser_disasm_line to browser_line. > > Link: http://lkml.kernel.org/n/tip-tttjkrcxaev97c90x78mpvon@git.kernel.org > Signed-off-by: Jiri Olsa both browser_disasm_line and disasm_line__browser lost the 'disasm' by using the generic annotation_line struct.. so there's no need to keep it in its name I'll update changelogs and resend/repush thanks, jirka