From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Leshenko Subject: [PATCH 3/5] KVM: x86: ioapic: Remove redundant check for Remote IRR in ioapic_set_irq Date: Sun, 5 Nov 2017 15:52:31 +0200 Message-ID: <20171105135233.34572-4-nikita.leshchenko@oracle.com> References: <20171105135233.34572-1-nikita.leshchenko@oracle.com> Cc: idan.brown@oracle.com, Nikita Leshenko , Konrad Rzeszutek Wilk To: kvm@vger.kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:48253 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577AbdKENxK (ORCPT ); Sun, 5 Nov 2017 08:53:10 -0500 In-Reply-To: <20171105135233.34572-1-nikita.leshchenko@oracle.com> Sender: kvm-owner@vger.kernel.org List-ID: Remote IRR for level-triggered interrupts was previously checked in ioapic_set_irq, but since we now have a check in ioapic_service we can remove the redundant check from ioapic_set_irq. This commit doesn't change semantics. Signed-off-by: Nikita Leshenko Reviewed-by: Liran Alon Signed-off-by: Konrad Rzeszutek Wilk --- arch/x86/kvm/ioapic.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/x86/kvm/ioapic.c b/arch/x86/kvm/ioapic.c index 5c9231139243..6df150eaaa78 100644 --- a/arch/x86/kvm/ioapic.c +++ b/arch/x86/kvm/ioapic.c @@ -209,12 +209,12 @@ static int ioapic_set_irq(struct kvm_ioapic *ioapic, unsigned int irq, old_irr = ioapic->irr; ioapic->irr |= mask; - if (edge) + if (edge) { ioapic->irr_delivered &= ~mask; - if ((edge && old_irr == ioapic->irr) || - (!edge && entry.fields.remote_irr)) { - ret = 0; - goto out; + if (old_irr == ioapic->irr) { + ret = 0; + goto out; + } } ret = ioapic_service(ioapic, irq, line_status); -- 2.13.3