From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751987AbdKFIFg (ORCPT ); Mon, 6 Nov 2017 03:05:36 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:48327 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbdKFIFe (ORCPT ); Mon, 6 Nov 2017 03:05:34 -0500 X-Google-Smtp-Source: ABhQp+S7j+6Fa0+mInRoZNDkGwfEqevZ1KtAWKtX0FwAdvlJI0atDm1qwaNsZkuOvX4VZVEC6x2SoQ== Date: Mon, 6 Nov 2017 17:05:28 +0900 From: Sergey Senozhatsky To: "Liu, Changcheng" Cc: Sergey Senozhatsky , jpoimboe@redhat.com, Petr Mladek , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0001/0001] format idle IP output func+offset/length Message-ID: <20171106080528.GA1298@jagdpanzerIV> References: <20171106052511.GB69364@sofia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171106052511.GB69364@sofia> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (11/06/17 13:25), Liu, Changcheng wrote: > kaslr feature is enabled in kernel. > Remove kernel text address when dumping idle IP info > > Signed-off-by: Liu Changcheng > Signed-off-by: Jerry Liu > > diff --git a/lib/nmi_backtrace.c b/lib/nmi_backtrace.c > index 0bc0a35..9cc4178 100644 > --- a/lib/nmi_backtrace.c > +++ b/lib/nmi_backtrace.c > @@ -92,7 +92,7 @@ bool nmi_cpu_backtrace(struct pt_regs *regs) > if (cpumask_test_cpu(cpu, to_cpumask(backtrace_mask))) { > arch_spin_lock(&lock); > if (regs && cpu_in_idle(instruction_pointer(regs))) { > - pr_warn("NMI backtrace for cpu %d skipped: idling at pc %#lx\n", > + pr_warn("NMI backtrace for cpu %d skipped: idling at pc %pS\n", I guess the word 'pc' can be dropped from the message ^^ there seems to be other cases in the kernel when we print regs->pc/regs->ip. -ss > cpu, instruction_pointer(regs)); > } else { > pr_warn("NMI backtrace for cpu %d\n", cpu);