From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754450AbdKFUJt (ORCPT ); Mon, 6 Nov 2017 15:09:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37136 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754388AbdKFUJs (ORCPT ); Mon, 6 Nov 2017 15:09:48 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0AC2FC047B66 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=alex.williamson@redhat.com Date: Mon, 6 Nov 2017 13:09:46 -0700 From: Alex Williamson To: Matthias Brugger Cc: joro@8bytes.org, sean.wang@mediatek.com, honghui.zhang@mediatek.com, iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] iommu/mediatek: Fix driver name Message-ID: <20171106130946.46a05132@t450s.home> In-Reply-To: <20171030113755.32408-1-matthias.bgg@gmail.com> References: <20171030113755.32408-1-matthias.bgg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 06 Nov 2017 20:09:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Oct 2017 12:37:55 +0100 Matthias Brugger wrote: > There exist two Mediatek iommu drivers for the two different > generations of the device. But both drivers have the same name > "mtk-iommu". This breaks the registration of the second driver: > > Error: Driver 'mtk-iommu' is already registered, aborting... > > Fix this by changing the name for first generation to > "mtk-iommu-v1". > > Fixes: b17336c55d89 ("iommu/mediatek: add support for mtk iommu generation one HW") > Signed-off-by: Matthias Brugger > --- > drivers/iommu/mtk_iommu_v1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c > index bc1efbfb9ddf..542930cd183d 100644 > --- a/drivers/iommu/mtk_iommu_v1.c > +++ b/drivers/iommu/mtk_iommu_v1.c > @@ -708,7 +708,7 @@ static struct platform_driver mtk_iommu_driver = { > .probe = mtk_iommu_probe, > .remove = mtk_iommu_remove, > .driver = { > - .name = "mtk-iommu", > + .name = "mtk-iommu-v1", > .of_match_table = mtk_iommu_of_ids, > .pm = &mtk_iommu_pm_ops, > } Applied to iommu/updates for v4.15. Thanks, Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH] iommu/mediatek: Fix driver name Date: Mon, 6 Nov 2017 13:09:46 -0700 Message-ID: <20171106130946.46a05132@t450s.home> References: <20171030113755.32408-1-matthias.bgg@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171030113755.32408-1-matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Matthias Brugger Cc: sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Mon, 30 Oct 2017 12:37:55 +0100 Matthias Brugger wrote: > There exist two Mediatek iommu drivers for the two different > generations of the device. But both drivers have the same name > "mtk-iommu". This breaks the registration of the second driver: > > Error: Driver 'mtk-iommu' is already registered, aborting... > > Fix this by changing the name for first generation to > "mtk-iommu-v1". > > Fixes: b17336c55d89 ("iommu/mediatek: add support for mtk iommu generation one HW") > Signed-off-by: Matthias Brugger > --- > drivers/iommu/mtk_iommu_v1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c > index bc1efbfb9ddf..542930cd183d 100644 > --- a/drivers/iommu/mtk_iommu_v1.c > +++ b/drivers/iommu/mtk_iommu_v1.c > @@ -708,7 +708,7 @@ static struct platform_driver mtk_iommu_driver = { > .probe = mtk_iommu_probe, > .remove = mtk_iommu_remove, > .driver = { > - .name = "mtk-iommu", > + .name = "mtk-iommu-v1", > .of_match_table = mtk_iommu_of_ids, > .pm = &mtk_iommu_pm_ops, > } Applied to iommu/updates for v4.15. Thanks, Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: alex.williamson@redhat.com (Alex Williamson) Date: Mon, 6 Nov 2017 13:09:46 -0700 Subject: [PATCH] iommu/mediatek: Fix driver name In-Reply-To: <20171030113755.32408-1-matthias.bgg@gmail.com> References: <20171030113755.32408-1-matthias.bgg@gmail.com> Message-ID: <20171106130946.46a05132@t450s.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 30 Oct 2017 12:37:55 +0100 Matthias Brugger wrote: > There exist two Mediatek iommu drivers for the two different > generations of the device. But both drivers have the same name > "mtk-iommu". This breaks the registration of the second driver: > > Error: Driver 'mtk-iommu' is already registered, aborting... > > Fix this by changing the name for first generation to > "mtk-iommu-v1". > > Fixes: b17336c55d89 ("iommu/mediatek: add support for mtk iommu generation one HW") > Signed-off-by: Matthias Brugger > --- > drivers/iommu/mtk_iommu_v1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c > index bc1efbfb9ddf..542930cd183d 100644 > --- a/drivers/iommu/mtk_iommu_v1.c > +++ b/drivers/iommu/mtk_iommu_v1.c > @@ -708,7 +708,7 @@ static struct platform_driver mtk_iommu_driver = { > .probe = mtk_iommu_probe, > .remove = mtk_iommu_remove, > .driver = { > - .name = "mtk-iommu", > + .name = "mtk-iommu-v1", > .of_match_table = mtk_iommu_of_ids, > .pm = &mtk_iommu_pm_ops, > } Applied to iommu/updates for v4.15. Thanks, Alex