From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754230AbdKFQu3 (ORCPT ); Mon, 6 Nov 2017 11:50:29 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:37616 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754184AbdKFQu1 (ORCPT ); Mon, 6 Nov 2017 11:50:27 -0500 Date: Mon, 6 Nov 2017 16:50:22 +0000 From: Dave Martin To: Arnd Bergmann Cc: Catalin Marinas , Will Deacon , "Luis R. Rodriguez" , Kees Cook , Alex =?iso-8859-1?Q?Benn=E9e?= , "Eric W. Biederman" , Andrew Morton , Thomas Gleixner , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH] sysctl: add register_sysctl() dummy helper Message-ID: <20171106165021.GV19485@e103592.cambridge.arm.com> References: <20171106133700.558647-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171106133700.558647-1-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 06, 2017 at 01:36:40PM +0000, Arnd Bergmann wrote: > The register_sysctl() function has been around for five years with commit > fea478d4101a ("sysctl: Add register_sysctl for normal sysctl users") > but now that arm64 started using it, I ran into a compile error: > > arch/arm64/kernel/armv8_deprecated.c: In function 'register_insn_emulation_sysctl': > arch/arm64/kernel/armv8_deprecated.c:257:2: error: implicit declaration of function 'register_sysctl' Hmmm, looks like I missed this combination in testing. I wonder whether ARMV8_DEPRECATED without SYSCTL is really a good idea though: in that config, we build a lot of dead code and leak some memory today. The default emulation is still potentially useful, but all the support for runtime twiddling of the emulation modes becomes useless. For parallel reasons, the SVE sysctl stuff is protected by #ifdef CONFIG_SYSCTL, which is why I didn't get a similar splat there. So, although this patch is superficially sensible, it may tend to hide bugs: code that calls register_sysctl() when CONFIG_SYSCTL=n is suspicious and probably needs review... no? Cheers ---Dave > This adds a inline function like we already have for register_sysctl_paths() > and register_sysctl_table(). > > Fixes: 38b9aeb32fa7 ("arm64: Port deprecated instruction emulation to new sysctl interface") > Signed-off-by: Arnd Bergmann > --- > This should probably get merged through the arm64 tree to avoid > bisection problems. > --- > include/linux/sysctl.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h > index fabe15e51c56..992bc9948232 100644 > --- a/include/linux/sysctl.h > +++ b/include/linux/sysctl.h > @@ -216,6 +216,11 @@ static inline struct ctl_table_header *register_sysctl_paths( > return NULL; > } > > +static inline struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table) > +{ > + return NULL; > +} > + > static inline void unregister_sysctl_table(struct ctl_table_header * table) > { > } > -- > 2.9.0