From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] turbovnc: new package
Date: Mon, 6 Nov 2017 21:59:34 +0200 [thread overview]
Message-ID: <20171106195934.tw433kt5ojiupxrg@tarshish> (raw)
In-Reply-To: <5A005FF1.5000204@petroprogram.com>
Hi Stefan,
On Mon, Nov 06, 2017 at 03:13:21PM +0200, Stefan Fr?berg wrote:
> 1. TurboVNC really does depend of turbo-jpeg, that's one of the reasons it's
> so fast. So for now I have made it "depends on BR2_PACKAGE_JPEG_TURBO" so
> that turbovnc package will only appear to menu only if jpeg-turbo has been
> also selected. Is that okay?
I don't think so.
The manual (?17.2.3) says you should "use a select type of dependency for
dependencies on libraries", and conversely "use a depends on type of
dependency when the user really needs to be aware of the dependency". In this
case there is nothing obvious about having to enable turbo-jpeg for turbovnc,
IMO.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2017-11-06 19:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 12:40 [Buildroot] [PATCH v2 1/1] turbovnc: new package Stefan Fröberg
2017-11-01 6:06 ` Baruch Siach
2017-11-01 9:53 ` Thomas Petazzoni
2017-11-02 21:21 ` Stefan Fröberg
2017-11-02 21:28 ` Thomas Petazzoni
2017-11-02 23:20 ` Stefan Fröberg
2017-11-03 22:17 ` Stefan Fröberg
2017-11-06 13:13 ` Stefan Fröberg
2017-11-06 19:59 ` Baruch Siach [this message]
2017-11-06 20:05 ` Thomas Petazzoni
2017-11-06 22:19 ` Arnout Vandecappelle
2017-11-06 22:38 ` Thomas Petazzoni
2017-11-07 13:28 ` Stefan Fröberg
2017-11-01 19:18 ` Stefan Fröberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106195934.tw433kt5ojiupxrg@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.