From: Rob Herring <robh@kernel.org>
To: Sven Van Asbroeck <svendev@arcx.com>
Cc: mark.rutland@arm.com, wsa@the-dreams.de, nsekhar@ti.com,
david@lechnology.com, javier@dowhile0.org, brgl@bgdev.pl,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 1/1] at24: support eeproms that do not roll over page reads.
Date: Mon, 6 Nov 2017 14:26:34 -0600 [thread overview]
Message-ID: <20171106202634.tuwdi76w6bmaqf4y@rob-hp-laptop> (raw)
In-Reply-To: <1509543843-27697-2-git-send-email-svendev@arcx.com>
On Wed, Nov 01, 2017 at 09:44:03AM -0400, Sven Van Asbroeck wrote:
> Some eeproms in the at24 family do not roll over page reads,
> e.g. the Microchip 24AA16/24LC16B. On those eeproms, reads
> that straddle block boundaries will not work correctly.
>
> Solution:
> Implement read rollover in the driver. To enable it, add the
> AT24_FLAG_NO_RDROL flag to the eeprom entry in the
> device_id table, or add 'no-read-rollover' to the eeprom
> devicetree entry.
>
> Signed-off-by: Sven Van Asbroeck <svendev@arcx.com>
> ---
> .../devicetree/bindings/eeprom/eeprom.txt | 5 +++
Acked-by: Rob Herring <robh@kernel.org>
> drivers/misc/eeprom/at24.c | 47 +++++++++++-----------
> include/linux/platform_data/at24.h | 1 +
> 3 files changed, 29 insertions(+), 24 deletions(-)
prev parent reply other threads:[~2017-11-06 20:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 13:44 [PATCH v2 0/1] at24: support eeproms that do not roll over page reads Sven Van Asbroeck
2017-11-01 13:44 ` Sven Van Asbroeck
2017-11-01 13:44 ` [PATCH v2 1/1] " Sven Van Asbroeck
2017-11-01 13:44 ` Sven Van Asbroeck
2017-11-06 20:26 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106202634.tuwdi76w6bmaqf4y@rob-hp-laptop \
--to=robh@kernel.org \
--cc=brgl@bgdev.pl \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@dowhile0.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=svendev@arcx.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.