From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH v10 2/9] PCI: remove unused __weak attribute in pci_register_io_range() Date: Mon, 6 Nov 2017 18:23:25 -0600 Message-ID: <20171107002325.GC9538@bhelgaas-glaptop.roam.corp.google.com> References: <1509120687-7352-1-git-send-email-gabriele.paoloni@huawei.com> <1509120687-7352-3-git-send-email-gabriele.paoloni@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1509120687-7352-3-git-send-email-gabriele.paoloni@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: Gabriele Paoloni Cc: catalin.marinas@arm.com, will.deacon@arm.com, robh+dt@kernel.org, frowand.list@gmail.com, bhelgaas@google.com, rafael@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, brian.starkey@arm.com, olof@lixom.net, benh@kernel.crashing.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linuxarm@huawei.com, linux-pci@vger.kernel.org, minyard@acm.org, john.garry@huawei.com, xuwei5@hisilicon.com List-Id: linux-acpi@vger.kernel.org > PCI: remove unused __weak attribute in pci_register_io_range() Please capitalize to follow drivers/pci convention, e.g., PCI: Remove __weak attribute from pci_register_io_range() (Also do the same for the other PCI patches.) On Fri, Oct 27, 2017 at 05:11:20PM +0100, Gabriele Paoloni wrote: > From: gabriele paoloni > > Currently pci_register_io_range() has only one definition; > therefore there is no use of the __weak attribute. > > Signed-off-by: Gabriele Paoloni > Acked-by: Bjorn Helgaas > --- > drivers/pci/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index af0cc34..eee967c 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock); > * Record the PCI IO range (expressed as CPU physical address + size). > * Return a negative value if an error has occured, zero otherwise > */ > -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t size) > +int pci_register_io_range(phys_addr_t addr, resource_size_t size) > { > int err = 0; > > -- > 2.7.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Mon, 6 Nov 2017 18:23:25 -0600 From: Bjorn Helgaas To: Gabriele Paoloni Subject: Re: [PATCH v10 2/9] PCI: remove unused __weak attribute in pci_register_io_range() Message-ID: <20171107002325.GC9538@bhelgaas-glaptop.roam.corp.google.com> References: <1509120687-7352-1-git-send-email-gabriele.paoloni@huawei.com> <1509120687-7352-3-git-send-email-gabriele.paoloni@huawei.com> MIME-Version: 1.0 In-Reply-To: <1509120687-7352-3-git-send-email-gabriele.paoloni@huawei.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, minyard@acm.org, lorenzo.pieralisi@arm.com, linux-acpi@vger.kernel.org, arnd@arndb.de, rafael@kernel.org, linux-pci@vger.kernel.org, catalin.marinas@arm.com, john.garry@huawei.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, xuwei5@hisilicon.com, linuxarm@huawei.com, olof@lixom.net, robh+dt@kernel.org, benh@kernel.crashing.org, bhelgaas@google.com, frowand.list@gmail.com, brian.starkey@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: > PCI: remove unused __weak attribute in pci_register_io_range() Please capitalize to follow drivers/pci convention, e.g., PCI: Remove __weak attribute from pci_register_io_range() (Also do the same for the other PCI patches.) On Fri, Oct 27, 2017 at 05:11:20PM +0100, Gabriele Paoloni wrote: > From: gabriele paoloni > > Currently pci_register_io_range() has only one definition; > therefore there is no use of the __weak attribute. > > Signed-off-by: Gabriele Paoloni > Acked-by: Bjorn Helgaas > --- > drivers/pci/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index af0cc34..eee967c 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock); > * Record the PCI IO range (expressed as CPU physical address + size). > * Return a negative value if an error has occured, zero otherwise > */ > -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t size) > +int pci_register_io_range(phys_addr_t addr, resource_size_t size) > { > int err = 0; > > -- > 2.7.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: helgaas@kernel.org (Bjorn Helgaas) Date: Mon, 6 Nov 2017 18:23:25 -0600 Subject: [PATCH v10 2/9] PCI: remove unused __weak attribute in pci_register_io_range() In-Reply-To: <1509120687-7352-3-git-send-email-gabriele.paoloni@huawei.com> References: <1509120687-7352-1-git-send-email-gabriele.paoloni@huawei.com> <1509120687-7352-3-git-send-email-gabriele.paoloni@huawei.com> Message-ID: <20171107002325.GC9538@bhelgaas-glaptop.roam.corp.google.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > PCI: remove unused __weak attribute in pci_register_io_range() Please capitalize to follow drivers/pci convention, e.g., PCI: Remove __weak attribute from pci_register_io_range() (Also do the same for the other PCI patches.) On Fri, Oct 27, 2017 at 05:11:20PM +0100, Gabriele Paoloni wrote: > From: gabriele paoloni > > Currently pci_register_io_range() has only one definition; > therefore there is no use of the __weak attribute. > > Signed-off-by: Gabriele Paoloni > Acked-by: Bjorn Helgaas > --- > drivers/pci/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index af0cc34..eee967c 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock); > * Record the PCI IO range (expressed as CPU physical address + size). > * Return a negative value if an error has occured, zero otherwise > */ > -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t size) > +int pci_register_io_range(phys_addr_t addr, resource_size_t size) > { > int err = 0; > > -- > 2.7.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html