From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBxqY-0008WF-WA for qemu-devel@nongnu.org; Tue, 07 Nov 2017 01:58:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBxqV-000825-TH for qemu-devel@nongnu.org; Tue, 07 Nov 2017 01:58:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46984) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eBxqV-00080B-N1 for qemu-devel@nongnu.org; Tue, 07 Nov 2017 01:58:51 -0500 Date: Tue, 7 Nov 2017 14:58:36 +0800 From: Fam Zheng Message-ID: <20171107065836.GK16355@lemon> References: <20171106094643.14881-1-peterx@redhat.com> <20171106094643.14881-8-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171106094643.14881-8-peterx@redhat.com> Subject: Re: [Qemu-devel] [RFC v3 07/27] monitor: move the cur_mon hack deeper for QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , "Daniel P . Berrange" , Paolo Bonzini , Jiri Denemark , Juan Quintela , mdroth@linux.vnet.ibm.com, Eric Blake , Laurent Vivier , marcandre.lureau@redhat.com, Markus Armbruster , "Dr . David Alan Gilbert" On Mon, 11/06 17:46, Peter Xu wrote: > In monitor_qmp_read(), we have the hack to temporarily replace the > cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher > routine since the Monitor pointer can be passed in to that using the new > JSON Parser opaque field now. > > This does not make much sense as a single patch. However, this will be > a big step for the next patch, when the QMP dispatcher routine will be > split from the QMP parser. > > Reviewed-by: Eric Blake > Signed-off-by: Peter Xu Reviewed-by: Fam Zheng