From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756652AbdKGJGp (ORCPT ); Tue, 7 Nov 2017 04:06:45 -0500 Received: from mx2.suse.de ([195.135.220.15]:47578 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbdKGJGi (ORCPT ); Tue, 7 Nov 2017 04:06:38 -0500 Date: Tue, 7 Nov 2017 10:06:35 +0100 From: Michal Hocko To: Andrew Morton , Johannes Weiner Cc: Vlastimil Babka , linux-mm@kvack.org, LKML Subject: Re: [PATCH] mm, sparse: do not swamp log with huge vmemmap allocation failures Message-ID: <20171107090635.c27thtse2lchjgvb@dhcp22.suse.cz> References: <20171106092228.31098-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171106092228.31098-1-mhocko@kernel.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dohh, forgot to git add the follow up fix on top of Johannes' original diff so it didn't make it into the finall commit. Could you fold this into the patch Andrew, please? Sorry about that. --- diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index 3f85084cb8bb..9a745e2a6f9a 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -62,7 +62,7 @@ void * __meminit vmemmap_alloc_block(unsigned long size, int node) return page_address(page); if (!warned) { - warn_alloc(gfp_mask, NULL, "vmemmap alloc failure: order:%u", order); + warn_alloc(gfp_mask & ~__GFP_NOWARN, NULL, "vmemmap alloc failure: order:%u", order); warned = true; } return NULL; -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f197.google.com (mail-wr0-f197.google.com [209.85.128.197]) by kanga.kvack.org (Postfix) with ESMTP id E51746B0297 for ; Tue, 7 Nov 2017 04:06:38 -0500 (EST) Received: by mail-wr0-f197.google.com with SMTP id c21so7407044wrg.16 for ; Tue, 07 Nov 2017 01:06:38 -0800 (PST) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id 92si738808edn.391.2017.11.07.01.06.37 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 07 Nov 2017 01:06:37 -0800 (PST) Date: Tue, 7 Nov 2017 10:06:35 +0100 From: Michal Hocko Subject: Re: [PATCH] mm, sparse: do not swamp log with huge vmemmap allocation failures Message-ID: <20171107090635.c27thtse2lchjgvb@dhcp22.suse.cz> References: <20171106092228.31098-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171106092228.31098-1-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton , Johannes Weiner Cc: Vlastimil Babka , linux-mm@kvack.org, LKML Dohh, forgot to git add the follow up fix on top of Johannes' original diff so it didn't make it into the finall commit. Could you fold this into the patch Andrew, please? Sorry about that. --- diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index 3f85084cb8bb..9a745e2a6f9a 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -62,7 +62,7 @@ void * __meminit vmemmap_alloc_block(unsigned long size, int node) return page_address(page); if (!warned) { - warn_alloc(gfp_mask, NULL, "vmemmap alloc failure: order:%u", order); + warn_alloc(gfp_mask & ~__GFP_NOWARN, NULL, "vmemmap alloc failure: order:%u", order); warned = true; } return NULL; -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org