From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH 6/8] staging: ccree: simplify pm manager using local var Date: Tue, 7 Nov 2017 13:43:10 +0300 Message-ID: <20171107104310.xhdxl3q3bnh7uciw@mwanda> References: <1510047606-5589-1-git-send-email-gilad@benyossef.com> <1510047606-5589-7-git-send-email-gilad@benyossef.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Ofir Drang To: Gilad Ben-Yossef Return-path: Content-Disposition: inline In-Reply-To: <1510047606-5589-7-git-send-email-gilad@benyossef.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: linux-crypto.vger.kernel.org On Tue, Nov 07, 2017 at 09:40:02AM +0000, Gilad Ben-Yossef wrote: > --- a/drivers/staging/ccree/ssi_pm.c > +++ b/drivers/staging/ccree/ssi_pm.c > @@ -90,20 +90,24 @@ int cc_pm_resume(struct device *dev) > int cc_pm_get(struct device *dev) > { > int rc = 0; > + struct ssi_drvdata *drvdata = > + (struct ssi_drvdata *)dev_get_drvdata(dev); No need to cast: struct ssi_drvdata *drvdata = dev_get_drvdata(dev); regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754840AbdKGKwT (ORCPT ); Tue, 7 Nov 2017 05:52:19 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:25051 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757252AbdKGKnZ (ORCPT ); Tue, 7 Nov 2017 05:43:25 -0500 Date: Tue, 7 Nov 2017 13:43:10 +0300 From: Dan Carpenter To: Gilad Ben-Yossef Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org, linux-crypto@vger.kernel.org, Ofir Drang Subject: Re: [PATCH 6/8] staging: ccree: simplify pm manager using local var Message-ID: <20171107104310.xhdxl3q3bnh7uciw@mwanda> References: <1510047606-5589-1-git-send-email-gilad@benyossef.com> <1510047606-5589-7-git-send-email-gilad@benyossef.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510047606-5589-7-git-send-email-gilad@benyossef.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 07, 2017 at 09:40:02AM +0000, Gilad Ben-Yossef wrote: > --- a/drivers/staging/ccree/ssi_pm.c > +++ b/drivers/staging/ccree/ssi_pm.c > @@ -90,20 +90,24 @@ int cc_pm_resume(struct device *dev) > int cc_pm_get(struct device *dev) > { > int rc = 0; > + struct ssi_drvdata *drvdata = > + (struct ssi_drvdata *)dev_get_drvdata(dev); No need to cast: struct ssi_drvdata *drvdata = dev_get_drvdata(dev); regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 7 Nov 2017 13:43:10 +0300 From: Dan Carpenter Subject: Re: [PATCH 6/8] staging: ccree: simplify pm manager using local var Message-ID: <20171107104310.xhdxl3q3bnh7uciw@mwanda> References: <1510047606-5589-1-git-send-email-gilad@benyossef.com> <1510047606-5589-7-git-send-email-gilad@benyossef.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1510047606-5589-7-git-send-email-gilad@benyossef.com> List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Gilad Ben-Yossef Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Ofir Drang On Tue, Nov 07, 2017 at 09:40:02AM +0000, Gilad Ben-Yossef wrote: > --- a/drivers/staging/ccree/ssi_pm.c > +++ b/drivers/staging/ccree/ssi_pm.c > @@ -90,20 +90,24 @@ int cc_pm_resume(struct device *dev) > int cc_pm_get(struct device *dev) > { > int rc = 0; > + struct ssi_drvdata *drvdata = > + (struct ssi_drvdata *)dev_get_drvdata(dev); No need to cast: struct ssi_drvdata *drvdata = dev_get_drvdata(dev); regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel