From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] objtool: Move sync check to a script
Date: Tue, 7 Nov 2017 07:31:08 -0600 [thread overview]
Message-ID: <20171107133108.ddwhwpa7b4bfrvmr@treble> (raw)
In-Reply-To: <20171107094621.kfpykhbncikmeyms@gmail.com>
On Tue, Nov 07, 2017 at 10:46:21AM +0100, Ingo Molnar wrote:
> Hm, this doesn't actually warn - it outputs the diff:
>
> triton:~/tip/tools/objtool> ./sync-check.sh
> triton:~/tip/tools/objtool> 99a100,109
> > /* Identifiers for segment registers */
> > #define INAT_SEG_REG_IGNORE 0
> > #define INAT_SEG_REG_DEFAULT 1
> > #define INAT_SEG_REG_CS 2
> > #define INAT_SEG_REG_SS 3
> > #define INAT_SEG_REG_DS 4
> > #define INAT_SEG_REG_ES 5
> > #define INAT_SEG_REG_FS 6
> > #define INAT_SEG_REG_GS 7
> >
>
> I fixed it to do:
>
> diff $file ../../$file > /dev/null ||
>
> (note the removal of '&')
>
> Then it outputs the right thing:
>
> triton:~/tip/tools/objtool> ./sync-check.sh
> Warning: synced file at 'tools/objtool/arch/x86/include/asm/inat.h' differs from latest kernel version at 'arch/x86/include/asm/inat.h'
Ah. I guess '&>' is a bash-ism, shorthand for redirecting both stdout
and stderr. It worked for me with bash 4.4.12. I guess you used a
different default shell?
--
Josh
next prev parent reply other threads:[~2017-11-07 13:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 13:21 [PATCH v2 0/2] objtool: sync cleanups Josh Poimboeuf
2017-11-06 13:21 ` [PATCH v2 1/2] objtool: Move synced files to their original relative locations Josh Poimboeuf
2017-11-07 9:52 ` [tip:core/objtool] " tip-bot for Josh Poimboeuf
2017-11-06 13:21 ` [PATCH v2 2/2] objtool: Move sync check to a script Josh Poimboeuf
2017-11-07 9:46 ` Ingo Molnar
2017-11-07 13:31 ` Josh Poimboeuf [this message]
2017-11-07 15:05 ` Ingo Molnar
2017-11-07 15:11 ` Josh Poimboeuf
2017-11-07 16:01 ` Ingo Molnar
2017-11-07 9:53 ` [tip:core/objtool] objtool: Move kernel headers/code " tip-bot for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107133108.ddwhwpa7b4bfrvmr@treble \
--to=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.