From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934371AbdKGOKy (ORCPT ); Tue, 7 Nov 2017 09:10:54 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:64408 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932811AbdKGOKw (ORCPT ); Tue, 7 Nov 2017 09:10:52 -0500 From: Arnd Bergmann To: Richard Henderson Cc: Ivan Kokshaysky , Matt Turner , Alexander Viro , y2038@lists.linaro.org, Deepa Dinamani , Arnd Bergmann , stable@vger.kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] alpha: osf_sys.c: fix put_tv32 regression Date: Tue, 7 Nov 2017 15:09:24 +0100 Message-Id: <20171107141029.3160278-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Zf6NKKHC+LRpX0JKvtMPcY+e/PDs60KJG/zT89bYzwb9NbHa1/W Sz6/k7TyXA0Qhl9C+PSaBL4PqK69HfnzY3L903H7RIMaJzr2gVE1YiTbySI/fWTPzKSauIL 9ln/kd7TSRo6w3dMB8TfZz06dSKaRLS76EDxH65PltVXqqCGuJs3zFvvDTUNKjDk0Z9eM/T Nq8+rcm5uxq8F6IG6OL3w== X-UI-Out-Filterresults: notjunk:1;V01:K0:d76qu0YXIvg=:rajfNhRo7N9u/Qjxmj8uRv 5yl96MXilfWFqU/DSaX1onSnqin2tsMQ15pf28oS71foJT9xgnIi8NkZAZSnt/3l/PMixCAHG 6EAyxY888fkA5w3IqaQsfeYDajt/9mQgZRiaX326MkvmF5jHd9/MIew47uuInpoRLZWd5utvd TbOr4o7FiS9fM4J1nYhPsntjYTyhc2GK75rN76FcSlzmcGBJwd5+KiC3DrOqfzs7ebyDHcxmN nHBnPRERdIrnmST60pHdcnKKjg5SSYehr9zFkOTomnzAOxaNulqIIUB/ONRTHE8w3WDZtFnTp 3egyNZjIpC7A/h8QkhF/BEmh9TV0fvI9nWHj/N7uGqTyN2R2VFxP5zkFsfNZZ2Yz989N8k5d4 21N/FzLVdwuDJxwdILhT2H730TVQ4k4nj5s5zeVwFy8ONBvJst4DUDWmt5LI+FnjIY110lS1J /TGyoMvgG9bEia/xx1tbouVJ8xvINKXC8KqGjU2BeeNygT1vnrBqaQLLr7niYk8mTTCr9RrnW dSv82tM9VXDLfKB9MIBJPnZiBeaosMGBfAXcgF/KOKEDZXAygC0r7C/aDkePHeX/c35DdfL1L BsiOAKGUUx3Q3qidOmTETsUiQp26HCVIcTK3fhYrefFWUYKa27LZ7yPDsIc22FtIagPrd0slB J0ha1hoiJGoxnzhbrqeOQsKaj8QZ3B3JzLbljsxCE8jnfFInhNJtnGdhFJISSX/2JomdOrHWy DK6S9hBtvtdZvP1M6xc0LUmxXAZZeDwm8H4HCA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There was a typo in the new version of put_tv32() that caused uninitialized stack data to be written back to user space, rather than writing the actual timeval for the emulation of gettimeofday(), wait4(), usleep_thread() and old_adjtimex(). This fixes it to write the correct data again. Cc: stable@vger.kernel.org Fixes: 1cc6c4635e9f ("osf_sys.c: switch handling of timeval32/itimerval32 to copy_{to,from}_user()") Signed-off-by: Arnd Bergmann --- arch/alpha/kernel/osf_sys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c index ce3a675c0c4b..75a5c35a2067 100644 --- a/arch/alpha/kernel/osf_sys.c +++ b/arch/alpha/kernel/osf_sys.c @@ -964,8 +964,8 @@ static inline long put_tv32(struct timeval32 __user *o, struct timeval *i) { return copy_to_user(o, &(struct timeval32){ - .tv_sec = o->tv_sec, - .tv_usec = o->tv_usec}, + .tv_sec = i->tv_sec, + .tv_usec = i->tv_usec}, sizeof(struct timeval32)); } -- 2.9.0