Re: [PATCH v2 2/6] drm/modeset-helper: Add simple modeset suspend/resume helpers

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2957 bytes --]

Hi Noralf,

I love your patch! Yet something to improve:

[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.14-rc8 next-20171106]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Noralf-Tr-nnes/drm-Add-simple-modeset-suspend-resume-helpers/20171107-141931
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
config: x86_64-randconfig-x000-201745 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/gpu/drm/drm_modeset_helper.c: In function 'drm_mode_config_helper_suspend':
>> drivers/gpu/drm/drm_modeset_helper.c:186:40: error: 'struct drm_device' has no member named 'fb_helper'
     drm_fb_helper_set_suspend_unlocked(dev->fb_helper, 1);
                                           ^~
   drivers/gpu/drm/drm_modeset_helper.c:189:41: error: 'struct drm_device' has no member named 'fb_helper'
      drm_fb_helper_set_suspend_unlocked(dev->fb_helper, 0);
                                            ^~
   drivers/gpu/drm/drm_modeset_helper.c: In function 'drm_mode_config_helper_resume':
   drivers/gpu/drm/drm_modeset_helper.c:229:40: error: 'struct drm_device' has no member named 'fb_helper'
     drm_fb_helper_set_suspend_unlocked(dev->fb_helper, 0);
                                           ^~

vim +186 drivers/gpu/drm/drm_modeset_helper.c

   162	
   163	/**
   164	 * drm_mode_config_helper_suspend - Modeset suspend helper
   165	 * @dev: DRM device
   166	 *
   167	 * This helper function takes care of suspending the modeset side. It disables
   168	 * output polling if initialized, suspends fbdev if used and finally calls
   169	 * drm_atomic_helper_suspend().
   170	 * If suspending fails, fbdev and polling is re-enabled.
   171	 *
   172	 * Returns:
   173	 * Zero on success, negative error code on error.
   174	 *
   175	 * See also:
   176	 * drm_kms_helper_poll_disable() and drm_fb_helper_set_suspend_unlocked().
   177	 */
   178	int drm_mode_config_helper_suspend(struct drm_device *dev)
   179	{
   180		struct drm_atomic_state *state;
   181	
   182		if (!dev)
   183			return 0;
   184	
   185		drm_kms_helper_poll_disable(dev);
 > 186		drm_fb_helper_set_suspend_unlocked(dev->fb_helper, 1);
   187		state = drm_atomic_helper_suspend(dev);
   188		if (IS_ERR(state)) {
   189			drm_fb_helper_set_suspend_unlocked(dev->fb_helper, 0);
   190			drm_kms_helper_poll_enable(dev);
   191			return PTR_ERR(state);
   192		}
   193	
   194		dev->mode_config.suspend_state = state;
   195	
   196		return 0;
   197	}
   198	EXPORT_SYMBOL(drm_mode_config_helper_suspend);
   199	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31510 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel