From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934475AbdKGOuU (ORCPT ); Tue, 7 Nov 2017 09:50:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39767 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933842AbdKGOuS (ORCPT ); Tue, 7 Nov 2017 09:50:18 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 86C1A8211D Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Tue, 7 Nov 2017 15:50:16 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , Ingo Molnar , Namhyung Kim , David Ahern , Peter Zijlstra , Andi Kleen Subject: Re: [PATCH 35/35] perf annotate: Align source and offset lines Message-ID: <20171107145016.GB23379@krava> References: <20171011150158.11895-1-jolsa@kernel.org> <20171011150158.11895-36-jolsa@kernel.org> <20171107141047.GF3216@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171107141047.GF3216@kernel.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 07 Nov 2017 14:50:18 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 07, 2017 at 11:10:47AM -0300, Arnaldo Carvalho de Melo wrote: SNIP > > Link: http://lkml.kernel.org/n/tip-uamk3iiewlii40o4mlog2cpp@git.kernel.org > > Signed-off-by: Jiri Olsa > > --- > > tools/perf/util/annotate.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c > > index 2516e53104be..530961a343fc 100644 > > --- a/tools/perf/util/annotate.c > > +++ b/tools/perf/util/annotate.c > > @@ -1082,6 +1082,7 @@ static void annotate__branch_printf(struct block_range *br, u64 addr) > > } > > } > > > > +#define ADDR_LEN 10 > > This doesn't align kernel addresses well, as they will take more > columns, so I'm trying the patch below, on top of yours, ok? > > I will combine both to elliminate unnecessary churn, ok? argh.. sounds good, thanks jirka