All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm/page_alloc: Avoid KERN_CONT uses in warn_alloc
@ 2017-11-06 18:02 ` Joe Perches
  0 siblings, 0 replies; 18+ messages in thread
From: Joe Perches @ 2017-11-06 18:02 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-mm

KERN_CONT/pr_cont uses should be avoided where possible.
Use single pr_warn calls instead.

Signed-off-by: Joe Perches <joe@perches.com>
---
 mm/page_alloc.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 536431bf0f0c..82e6d2c914ab 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3275,19 +3275,17 @@ void warn_alloc(gfp_t gfp_mask, nodemask_t *nodemask, const char *fmt, ...)
 	if ((gfp_mask & __GFP_NOWARN) || !__ratelimit(&nopage_rs))
 		return;
 
-	pr_warn("%s: ", current->comm);
-
 	va_start(args, fmt);
 	vaf.fmt = fmt;
 	vaf.va = &args;
-	pr_cont("%pV", &vaf);
-	va_end(args);
-
-	pr_cont(", mode:%#x(%pGg), nodemask=", gfp_mask, &gfp_mask);
 	if (nodemask)
-		pr_cont("%*pbl\n", nodemask_pr_args(nodemask));
+		pr_warn("%s: %pV, mode:%#x(%pGg), nodemask=%*pbl\n",
+			current->comm, &vaf, gfp_mask, &gfp_mask,
+			nodemask_pr_args(nodemask));
 	else
-		pr_cont("(null)\n");
+		pr_warn("%s: %pV, mode:%#x(%pGg), nodemask=(null)\n",
+			current->comm, &vaf, gfp_mask, &gfp_mask);
+	va_end(args);
 
 	cpuset_print_current_mems_allowed();
 
-- 
2.15.0

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2017-11-09 16:27 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-06 18:02 [PATCH] mm/page_alloc: Avoid KERN_CONT uses in warn_alloc Joe Perches
2017-11-06 18:02 ` Joe Perches
2017-11-07 12:50 ` Michal Hocko
2017-11-07 12:50   ` Michal Hocko
2017-11-07 15:34   ` Joe Perches
2017-11-07 15:34     ` Joe Perches
2017-11-07 15:43     ` Michal Hocko
2017-11-07 15:43       ` Michal Hocko
2017-11-07 16:03       ` Joe Perches
2017-11-07 16:03         ` Joe Perches
2017-11-09 10:05         ` Michal Hocko
2017-11-09 10:05           ` Michal Hocko
2017-11-09 15:49           ` Joe Perches
2017-11-09 15:49             ` Joe Perches
2017-11-09 16:03             ` Michal Hocko
2017-11-09 16:03               ` Michal Hocko
2017-11-09 16:27           ` Joe Perches
2017-11-09 16:27             ` Joe Perches

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.