From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wim ten Have Subject: Re: [libvirt] Libvirt config converter can't handle file not ending with new line Date: Tue, 7 Nov 2017 16:54:13 +0100 Message-ID: <20171107165413.57c06835.wim.ten.have__18994.8665247814$1510070165$gmane$org@oracle.com> References: <20171030121726.g4zfucosj3oum2nu@citrix.com> <20171107122005.gn3h75z5oqa25nyw@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eC6Cp-0000iS-Sb for xen-devel@lists.xenproject.org; Tue, 07 Nov 2017 15:54:27 +0000 In-Reply-To: <20171107122005.gn3h75z5oqa25nyw@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: libvir-list@redhat.com, Xen-devel , Jim Fehlig , Ian Jackson , Wim ten Have List-Id: xen-devel@lists.xenproject.org T24gVHVlLCA3IE5vdiAyMDE3IDEyOjIwOjA1ICswMDAwCldlaSBMaXUgPHdlaS5saXUyQGNpdHJp eC5jb20+IHdyb3RlOgoKPiBPbiBNb24sIE5vdiAwNiwgMjAxNyBhdCAwOTo0MTowMVBNIC0wNzAw LCBKaW0gRmVobGlnIHdyb3RlOgo+ID4gT24gMTAvMzAvMjAxNyAwNjoxNyBBTSwgV2VpIExpdSB3 cm90ZTogIAo+ID4gPiBIaSBKaW0KPiA+ID4gCj4gPiA+IEkgZGlzY292ZXIgYSBwcm9ibGVtIHdo ZW4gdXNpbmcgeGVuX3hsIGNvbnZlcnRlci4gV2hlbiB0aGUgZmlsZSBpbgo+ID4gPiBxdWVzdGlv biBkb2Vzbid0IGVuZCB3aXRoIGEgbmV3IGxpbmUsIEkgZ2V0IHRoZSBmb2xsb3dpbmcgZXJyb3I6 Cj4gPiA+IAo+ID4gPiAgICBlcnJvcjogY29uZmlndXJhdGlvbiBmaWxlIHN5bnRheCBlcnJvcjog bWVtb3J5IGNvbmY6NTM6IGV4cGVjdGluZyBhIHZhbHVlICAKPiA+IAo+ID4gSSdtIG5vdCBhYmxl IHRvIHJlcHJvZHVjZSB0aGlzIGlzc3VlLiBUaGUgbGlidmlydC5naXQgdHJlZSBJIHRyaWVkIHdh cyBhIGJpdAo+ID4gZGF0ZWQsIGJ1dCBldmVuIGFmdGVyIHVwZGF0aW5nIHRvIGxhdGVzdCBtYXN0 ZXIgSSBjYW4ndCByZXByb2R1Y2UuCj4gPiAgIAo+ID4gPiBBZnRlciBkaWdnaW5nIGEgYml0IChi dXQgaGF2ZW4ndCByZWFkIGxpYnZpcnQgY29kZSksIGl0IGFwcGVhcnMgdGhhdCB0aGUKPiA+ID4g ZmlsZSBkaWRuJ3QgZW5kIHdpdGggYSBuZXcgbGluZS4gIAo+ID4gCj4gPiBJIHRyaWVkIHNldmVy YWwgZmlsZXMgd2l0aG91dCBlbmRpbmcgbmV3IGxpbmVzLCBnb2luZyBib3RoIGRpcmVjdGlvbnMK PiA+IChkb214bWwtdG8tbmF0aXZlIGFuZCBkb214bWwtZnJvbS1uYXRpdmUpLCBidXQgZGlkbid0 IHNlZSB0aGUgbWVudGlvbmVkCj4gPiBlcnJvci4gUGVyaGFwcyB5b3VyIGNvbmZpZyBpcyByZXZl YWxpbmcgYW5vdGhlciBidWcgd2hpY2ggaXMgYmVpbmcKPiA+IGltcHJvcGVybHkgcmVwb3J0ZWQu IENhbiB5b3UgcHJvdmlkZSBhbiBleGFtcGxlIG9mIHRoZSBwcm9ibGVtYXRpYyBjb25maWc/Cj4g PiAgIAo+IAo+IEkgdHJpZWQgdG8gZ2V0IHRoZSBleGFjdCBmaWxlIHRoYXQgY2F1c2VkIHRoZSBw cm9ibGVtIGJ1dCBpdCBpcyBhbHJlYWR5Cj4gZGVzdHJveWVkIGJ5IG9zc3Rlc3QuCj4gCj4gQSBz aW1pbGFyIGZpbGU6Cj4gCj4gaHR0cDovL2xvZ3MudGVzdC1sYWIueGVucHJvamVjdC5vcmcvb3Nz dGVzdC9sb2dzLzExNTQzNi90ZXN0LWFtZDY0LWFtZDY0LWxpYnZpcnQtcGFpci9kZWJpYW4uZ3Vl c3Qub3NzdGVzdC5jZmcKPiAKPiBJZiB5b3UgaGV4ZHVtcCAtQyBpdCwgeW91IGNhbiBzZWUgdGhl IGxhc3QgY2hhcmFjdGVyIGlzIDBhLiBSZW1vdmUgaXQgYW5kCj4gZmVlZCB0aGUgZmlsZSBpbnRv IHRoZSBjb252ZXJ0ZXIuCj4gV2VpLgoKICBUaGUgcGhlbm9ub21lbSB5b3UgcG9pbnQgb3V0IGlz IGluZGVlZCB3ZWlyZC4gIEFuZCBteSBmaXJzdCByZXNwb25zZQogIGlzIHRoYXQgdGhpcyBpcyBh IGJ1ZyBwYXJzaW5nIHRoZSBjZmcgaW5wdXQuICBJIGRpZCBsaXR0bGUgZXhwbG9yZSBhbmQKICB0 aGluayB0aGF0IHNyYy91dGlsL3ZpcmNvbmYuYyAodmlyQ29uZlBhcnNlTG9uZygpLCB2aXJDb25m UGFyc2VWYWx1ZSgpKSAKICBzaG91bGQgYmUgcmV3b3JrZWQgYXMgcG9pbnRlZCBvdXQgaW4gYmVs b3cgY29udGV4dCBkaWZmcy4KCgk8d3RlbmhhdmVAbmluYToxNDA+IGdpdCBkaWZmCglkaWZmIC0t Z2l0IGEvc3JjL3V0aWwvdmlyY29uZi5jIGIvc3JjL3V0aWwvdmlyY29uZi5jCglpbmRleCAzOWMy YmQ5MTcuLmJjOGU1N2VjMyAxMDA2NDQKCS0tLSBhL3NyYy91dGlsL3ZpcmNvbmYuYwoJKysrIGIv c3JjL3V0aWwvdmlyY29uZi5jCglAQCAtMzUyLDcgKzM1Miw3IEBAIHZpckNvbmZQYXJzZUxvbmco dmlyQ29uZlBhcnNlckN0eHRQdHIgY3R4dCwgbG9uZyBsb25nICp2YWwpCgkgICAgIH0gZWxzZSBp ZiAoQ1VSID09ICcrJykgewoJICAgICAgICAgTkVYVDsKCSAgICAgfQoJLSAgICBpZiAoKGN0eHQt PmN1ciA+PSBjdHh0LT5lbmQpIHx8ICghY19pc2RpZ2l0KENVUikpKSB7CgkrICAgIGlmICgoY3R4 dC0+Y3VyID4gY3R4dC0+ZW5kKSB8fCAoIWNfaXNkaWdpdChDVVIpKSkgewoJICAgICAgICAgdmly Q29uZkVycm9yKGN0eHQsIFZJUl9FUlJfQ09ORl9TWU5UQVgsIF8oInVudGVybWluYXRlZCBudW1i ZXIiKSk7CgkgICAgICAgICByZXR1cm4gLTE7CgkgICAgIH0KCUBAIC00NTYsNyArNDU2LDcgQEAg dmlyQ29uZlBhcnNlVmFsdWUodmlyQ29uZlBhcnNlckN0eHRQdHIgY3R4dCkKCSAgICAgbG9uZyBs b25nIGwgPSAwOwoJIAoJICAgICBTS0lQX0JMQU5LUzsKCS0gICAgaWYgKGN0eHQtPmN1ciA+PSBj dHh0LT5lbmQpIHsKCSsgICAgaWYgKGN0eHQtPmN1ciA+IGN0eHQtPmVuZCkgewoJICAgICAgICAg dmlyQ29uZkVycm9yKGN0eHQsIFZJUl9FUlJfQ09ORl9TWU5UQVgsIF8oImV4cGVjdGluZyBhIHZh bHVlIikpOwoJICAgICAgICAgcmV0dXJuIE5VTEw7CgkgICAgIH0KCiAgSSBkaWQgbm90IGdvIGJl eW9uZCB0aGlzIHlldC4KClJnZHMsCi0gV2ltLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlz dHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==