All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: comedi: usbdux: remove redundant initialization of val
@ 2017-11-07 19:07 ` Colin King
  0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2017-11-07 19:07 UTC (permalink / raw)
  To: Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman, devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The early initialization of val is redundant as the value is never
read and is updated inside a for-loop. Remove the initialization
and move the declaration and initialization to the for-loop scope.
Cleans up clang warning:

drivers/staging/comedi/drivers/usbdux.c:812:15: warning: Value stored
to 'val' during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/staging/comedi/drivers/usbdux.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
index f4f05d29d30d..ede064b47aac 100644
--- a/drivers/staging/comedi/drivers/usbdux.c
+++ b/drivers/staging/comedi/drivers/usbdux.c
@@ -809,7 +809,6 @@ static int usbdux_ao_insn_write(struct comedi_device *dev,
 {
 	struct usbdux_private *devpriv = dev->private;
 	unsigned int chan = CR_CHAN(insn->chanspec);
-	unsigned int val = s->readback[chan];
 	__le16 *p = (__le16 *)&devpriv->dux_commands[2];
 	int ret = -EBUSY;
 	int i;
@@ -825,7 +824,7 @@ static int usbdux_ao_insn_write(struct comedi_device *dev,
 	devpriv->dux_commands[4] = chan << 6;
 
 	for (i = 0; i < insn->n; i++) {
-		val = data[i];
+		unsigned int val = data[i];
 
 		/* one 16 bit value */
 		*p = cpu_to_le16(val);
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] staging: comedi: usbdux: remove redundant initialization of val
@ 2017-11-07 19:07 ` Colin King
  0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2017-11-07 19:07 UTC (permalink / raw)
  To: Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman, devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The early initialization of val is redundant as the value is never
read and is updated inside a for-loop. Remove the initialization
and move the declaration and initialization to the for-loop scope.
Cleans up clang warning:

drivers/staging/comedi/drivers/usbdux.c:812:15: warning: Value stored
to 'val' during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/staging/comedi/drivers/usbdux.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
index f4f05d29d30d..ede064b47aac 100644
--- a/drivers/staging/comedi/drivers/usbdux.c
+++ b/drivers/staging/comedi/drivers/usbdux.c
@@ -809,7 +809,6 @@ static int usbdux_ao_insn_write(struct comedi_device *dev,
 {
 	struct usbdux_private *devpriv = dev->private;
 	unsigned int chan = CR_CHAN(insn->chanspec);
-	unsigned int val = s->readback[chan];
 	__le16 *p = (__le16 *)&devpriv->dux_commands[2];
 	int ret = -EBUSY;
 	int i;
@@ -825,7 +824,7 @@ static int usbdux_ao_insn_write(struct comedi_device *dev,
 	devpriv->dux_commands[4] = chan << 6;
 
 	for (i = 0; i < insn->n; i++) {
-		val = data[i];
+		unsigned int val = data[i];
 
 		/* one 16 bit value */
 		*p = cpu_to_le16(val);
-- 
2.14.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] staging: comedi: usbdux: remove redundant initialization of val
  2017-11-07 19:07 ` Colin King
@ 2017-11-08 11:04   ` Ian Abbott
  -1 siblings, 0 replies; 4+ messages in thread
From: Ian Abbott @ 2017-11-08 11:04 UTC (permalink / raw)
  To: Colin King, H Hartley Sweeten, Greg Kroah-Hartman, devel
  Cc: kernel-janitors, linux-kernel

On 07/11/17 19:07, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The early initialization of val is redundant as the value is never
> read and is updated inside a for-loop. Remove the initialization
> and move the declaration and initialization to the for-loop scope.
> Cleans up clang warning:
> 
> drivers/staging/comedi/drivers/usbdux.c:812:15: warning: Value stored
> to 'val' during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/staging/comedi/drivers/usbdux.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
> index f4f05d29d30d..ede064b47aac 100644
> --- a/drivers/staging/comedi/drivers/usbdux.c
> +++ b/drivers/staging/comedi/drivers/usbdux.c
> @@ -809,7 +809,6 @@ static int usbdux_ao_insn_write(struct comedi_device *dev,
>   {
>   	struct usbdux_private *devpriv = dev->private;
>   	unsigned int chan = CR_CHAN(insn->chanspec);
> -	unsigned int val = s->readback[chan];
>   	__le16 *p = (__le16 *)&devpriv->dux_commands[2];
>   	int ret = -EBUSY;
>   	int i;
> @@ -825,7 +824,7 @@ static int usbdux_ao_insn_write(struct comedi_device *dev,
>   	devpriv->dux_commands[4] = chan << 6;
>   
>   	for (i = 0; i < insn->n; i++) {
> -		val = data[i];
> +		unsigned int val = data[i];
>   
>   		/* one 16 bit value */
>   		*p = cpu_to_le16(val);
> 

Thanks for catching that.  It looks like it has been redundant since 
commit 65a847477f63 ("staging: comedi: usbdux: use comedi_subdevice 
'readback'").

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] staging: comedi: usbdux: remove redundant initialization of val
@ 2017-11-08 11:04   ` Ian Abbott
  0 siblings, 0 replies; 4+ messages in thread
From: Ian Abbott @ 2017-11-08 11:04 UTC (permalink / raw)
  To: Colin King, H Hartley Sweeten, Greg Kroah-Hartman, devel
  Cc: kernel-janitors, linux-kernel

On 07/11/17 19:07, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The early initialization of val is redundant as the value is never
> read and is updated inside a for-loop. Remove the initialization
> and move the declaration and initialization to the for-loop scope.
> Cleans up clang warning:
> 
> drivers/staging/comedi/drivers/usbdux.c:812:15: warning: Value stored
> to 'val' during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/staging/comedi/drivers/usbdux.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
> index f4f05d29d30d..ede064b47aac 100644
> --- a/drivers/staging/comedi/drivers/usbdux.c
> +++ b/drivers/staging/comedi/drivers/usbdux.c
> @@ -809,7 +809,6 @@ static int usbdux_ao_insn_write(struct comedi_device *dev,
>   {
>   	struct usbdux_private *devpriv = dev->private;
>   	unsigned int chan = CR_CHAN(insn->chanspec);
> -	unsigned int val = s->readback[chan];
>   	__le16 *p = (__le16 *)&devpriv->dux_commands[2];
>   	int ret = -EBUSY;
>   	int i;
> @@ -825,7 +824,7 @@ static int usbdux_ao_insn_write(struct comedi_device *dev,
>   	devpriv->dux_commands[4] = chan << 6;
>   
>   	for (i = 0; i < insn->n; i++) {
> -		val = data[i];
> +		unsigned int val = data[i];
>   
>   		/* one 16 bit value */
>   		*p = cpu_to_le16(val);
> 

Thanks for catching that.  It looks like it has been redundant since 
commit 65a847477f63 ("staging: comedi: usbdux: use comedi_subdevice 
'readback'").

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-08 11:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-07 19:07 [PATCH] staging: comedi: usbdux: remove redundant initialization of val Colin King
2017-11-07 19:07 ` Colin King
2017-11-08 11:04 ` Ian Abbott
2017-11-08 11:04   ` Ian Abbott

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.