From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755557AbdKGWQC (ORCPT ); Tue, 7 Nov 2017 17:16:02 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:60446 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751789AbdKGWQA (ORCPT ); Tue, 7 Nov 2017 17:16:00 -0500 Date: Tue, 7 Nov 2017 14:15:55 -0800 From: "Paul E. McKenney" To: Peter Zijlstra Cc: Jeremy Linton , linux-kernel@vger.kernel.org, mingo@redhat.com, dave@stgolabs.net, josh@joshtriplett.org Subject: Re: [PATCH] locktorture: Fix Oops when reader/writer count is 0 Reply-To: paulmck@linux.vnet.ibm.com References: <20171010155248.11602-1-jeremy.linton@arm.com> <20171107210748.GR3165@worktop.lehotels.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171107210748.GR3165@worktop.lehotels.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17110722-0044-0000-0000-000003ABCAA9 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008028; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000239; SDB=6.00942609; UDB=6.00475504; IPR=6.00722896; BA=6.00005677; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017901; XFM=3.00000015; UTC=2017-11-07 22:15:58 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17110722-0045-0000-0000-000007DAE371 Message-Id: <20171107221555.GX3624@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-07_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1711070291 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 07, 2017 at 10:07:48PM +0100, Peter Zijlstra wrote: > On Tue, Nov 07, 2017 at 02:01:58PM -0600, Jeremy Linton wrote: > > Hi, > > > > On 10/10/2017 10:52 AM, Jeremy Linton wrote: > > >If nwriters_stress=0 is passed to the lock torture test > > >it will panic in: > > > > Ping? > > > > Has anyone had a chance to look at this? > > Helps if you Cc the people actually working on this stuff of course... Thank you for the forward, Peter, I have queued Jeremy's patch for testing and review. But Jeremy's list of email addresses is what you would expect from looking at MAINTAINERS, so how about the following patch? Thanx, Paul ------------------------------------------------------------------------ commit 58322063498c8f5a3cc88f95bee237a0ce81f70a Author: Paul E. McKenney Date: Tue Nov 7 14:10:03 2017 -0800 torture: Place all torture-test modules in one MAINTAINERS group There is some confusion about where patches to kernel/torture.c and kernel/locking/locktorture.c should be sent. This commit therefore updates MAINTAINERS appropriately. Reported-by: Peter Zijlstra Signed-off-by: Paul E. McKenney diff --git a/MAINTAINERS b/MAINTAINERS index 2d3d750b19c0..eab868adedc6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8091,6 +8091,7 @@ F: arch/*/include/asm/rwsem.h F: include/linux/seqlock.h F: lib/locking*.[ch] F: kernel/locking/ +X: kernel/locking/locktorture.c LOGICAL DISK MANAGER SUPPORT (LDM, Windows 2000/XP/Vista Dynamic Disks) M: "Richard Russon (FlatCap)" @@ -11318,15 +11319,6 @@ L: linux-wireless@vger.kernel.org S: Orphan F: drivers/net/wireless/ray* -RCUTORTURE MODULE -M: Josh Triplett -M: "Paul E. McKenney" -L: linux-kernel@vger.kernel.org -S: Supported -T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git -F: Documentation/RCU/torture.txt -F: kernel/rcu/rcutorture.c - RCUTORTURE TEST FRAMEWORK M: "Paul E. McKenney" M: Josh Triplett @@ -13558,6 +13550,18 @@ L: platform-driver-x86@vger.kernel.org S: Maintained F: drivers/platform/x86/topstar-laptop.c +TORTURE-TEST MODULES +M: Davidlohr Bueso +M: "Paul E. McKenney" +M: Josh Triplett +L: linux-kernel@vger.kernel.org +S: Supported +T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git +F: Documentation/RCU/torture.txt +F: kernel/torture.c +F: kernel/rcu/rcutorture.c +F: kernel/locking/locktorture.c + TOSHIBA ACPI EXTRAS DRIVER M: Azael Avalos L: platform-driver-x86@vger.kernel.org