From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: regression: UFO removal breaks kvm live migration
Date: Wed, 08 Nov 2017 15:26:24 +0900 (KST)
Message-ID: <20171108.152624.282888162096095926.davem@davemloft.net>
References: <20171107080224.v6z65jvimpa5ohs4@unicorn.suse.cz>
        <CAF=yD-+KdzpOUgVPa96=PKj3ak7x-gx+fs0D43KBPfbgfjYg3w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: mkubecek@suse.cz, netdev@vger.kernel.org
To: willemdebruijn.kernel@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:35332 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754957AbdKHG0d (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 8 Nov 2017 01:26:33 -0500
In-Reply-To: <CAF=yD-+KdzpOUgVPa96=PKj3ak7x-gx+fs0D43KBPfbgfjYg3w@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Wed, 8 Nov 2017 12:36:26 +0900

> On Tue, Nov 7, 2017 at 5:02 PM, Michal Kubecek <mkubecek@suse.cz> wrote:
>> I didn't have time to think it through yet but perhaps we could allow
>> setting TUN_F_UFO and ignore its value.
> 
> If the feature is enabled guests may try to send UFO packets, which
> the host is no longer able to fragment.
> 
> virtio_net_hdr_to_skb will drop the packets immediately based on
> gso_type and tun_get_user will return EINVAL.
> 
> Still, perhaps that's preferable as migration will succeed and most
> guests won't ever try to send those packets in the first place.

However, this would create the situation where there is no way
to properly probe for the actual presence of UFO support.