All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Alexey Perevalov <a.perevalov@samsung.com>,
	"Daniel P . Berrange" <berrange@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	peterx@redhat.com
Subject: [Qemu-devel] [PATCH v4 25/32] migration: return incoming task tag for exec
Date: Wed,  8 Nov 2017 14:01:23 +0800	[thread overview]
Message-ID: <20171108060130.3772-26-peterx@redhat.com> (raw)
In-Reply-To: <20171108060130.3772-1-peterx@redhat.com>

Return the async task tag for exec typed incoming migration in
exec_start_incoming_migration().

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/exec.c | 18 +++++++++++-------
 migration/exec.h |  2 +-
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/migration/exec.c b/migration/exec.c
index f3be1baf2e..a0796c2c70 100644
--- a/migration/exec.c
+++ b/migration/exec.c
@@ -52,7 +52,11 @@ static gboolean exec_accept_incoming_migration(QIOChannel *ioc,
     return G_SOURCE_REMOVE;
 }
 
-void exec_start_incoming_migration(const char *command, Error **errp)
+/*
+ * Returns the tag ID of the watch that is attached to global main
+ * loop (>0), or zero if failure detected.
+ */
+guint exec_start_incoming_migration(const char *command, Error **errp)
 {
     QIOChannel *ioc;
     const char *argv[] = { "/bin/sh", "-c", command, NULL };
@@ -62,13 +66,13 @@ void exec_start_incoming_migration(const char *command, Error **errp)
                                                     O_RDWR,
                                                     errp));
     if (!ioc) {
-        return;
+        return 0;
     }
 
     qio_channel_set_name(ioc, "migration-exec-incoming");
-    qio_channel_add_watch(ioc,
-                          G_IO_IN,
-                          exec_accept_incoming_migration,
-                          NULL,
-                          NULL);
+    return qio_channel_add_watch(ioc,
+                                 G_IO_IN,
+                                 exec_accept_incoming_migration,
+                                 NULL,
+                                 NULL);
 }
diff --git a/migration/exec.h b/migration/exec.h
index b210ffde7a..0a7aadacd3 100644
--- a/migration/exec.h
+++ b/migration/exec.h
@@ -19,7 +19,7 @@
 
 #ifndef QEMU_MIGRATION_EXEC_H
 #define QEMU_MIGRATION_EXEC_H
-void exec_start_incoming_migration(const char *host_port, Error **errp);
+guint exec_start_incoming_migration(const char *host_port, Error **errp);
 
 void exec_start_outgoing_migration(MigrationState *s, const char *host_port,
                                    Error **errp);
-- 
2.13.6

  parent reply	other threads:[~2017-11-08  6:11 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08  6:00 [Qemu-devel] [PATCH v4 00/32] Migration: postcopy failure recovery Peter Xu
2017-11-08  6:00 ` [Qemu-devel] [PATCH v4 01/32] migration: better error handling with QEMUFile Peter Xu
2017-11-30 10:24   ` Dr. David Alan Gilbert
2017-12-01  8:39     ` Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 02/32] migration: reuse mis->userfault_quit_fd Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 03/32] migration: provide postcopy_fault_thread_notify() Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 04/32] migration: new postcopy-pause state Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 05/32] migration: implement "postcopy-pause" src logic Peter Xu
2017-11-30 10:49   ` Dr. David Alan Gilbert
2017-12-01  8:56     ` Peter Xu
2017-12-01 10:49       ` Dr. David Alan Gilbert
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 06/32] migration: allow dst vm pause on postcopy Peter Xu
2017-11-30 11:17   ` Dr. David Alan Gilbert
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 07/32] migration: allow src return path to pause Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 08/32] migration: allow send_rq to fail Peter Xu
2017-11-30 12:13   ` Dr. David Alan Gilbert
2017-12-01  9:30     ` Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 09/32] migration: allow fault thread to pause Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 10/32] qmp: hmp: add migrate "resume" option Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 11/32] migration: pass MigrationState to migrate_init() Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 12/32] migration: rebuild channel on source Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 13/32] migration: new state "postcopy-recover" Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 14/32] migration: wakeup dst ram-load-thread for recover Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 15/32] migration: new cmd MIG_CMD_RECV_BITMAP Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 16/32] migration: new message MIG_RP_MSG_RECV_BITMAP Peter Xu
2017-11-30 17:21   ` Dr. David Alan Gilbert
2017-12-01  9:37     ` Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 17/32] migration: new cmd MIG_CMD_POSTCOPY_RESUME Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 18/32] migration: new message MIG_RP_MSG_RESUME_ACK Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 19/32] migration: introduce SaveVMHandlers.resume_prepare Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 20/32] migration: synchronize dirty bitmap for resume Peter Xu
2017-11-30 18:40   ` Dr. David Alan Gilbert
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 21/32] migration: setup ramstate " Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 22/32] migration: final handshake for the resume Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 23/32] migration: free SocketAddress where allocated Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 24/32] migration: return incoming task tag for sockets Peter Xu
2017-11-08  6:01 ` Peter Xu [this message]
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 26/32] migration: return incoming task tag for fd Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 27/32] migration: store listen task tag Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 28/32] migration: allow migrate_incoming for paused VM Peter Xu
2017-12-01 17:21   ` Dr. David Alan Gilbert
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 29/32] migration: init dst in migration_object_init too Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 30/32] migration: delay the postcopy-active state switch Peter Xu
2017-12-01 12:34   ` Dr. David Alan Gilbert
2017-12-04  4:14     ` Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 31/32] migration, qmp: new command "migrate-pause" Peter Xu
2017-12-01 16:53   ` Dr. David Alan Gilbert
2017-12-04  4:48     ` Peter Xu
2017-12-04 17:10       ` Dr. David Alan Gilbert
2017-12-05  2:52         ` Peter Xu
2017-11-08  6:01 ` [Qemu-devel] [PATCH v4 32/32] migration, hmp: new command "migrate_pause" Peter Xu
2017-11-30 20:00 ` [Qemu-devel] [PATCH v4 00/32] Migration: postcopy failure recovery Dr. David Alan Gilbert
2017-12-01 10:23   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171108060130.3772-26-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=a.perevalov@samsung.com \
    --cc=aarcange@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.