From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb() Date: Wed, 8 Nov 2017 12:47:27 +0530 Message-ID: <20171108071726.GA21113@jerin> References: <1510121832-16439-1-git-send-email-hejianet@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, olivier.matz@6wind.com, konstantin.ananyev@intel.com, bruce.richardson@intel.com, jianbo.liu@arm.com, hemant.agrawal@nxp.com, jia.he@hxt-semitech.com To: Jia He Return-path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01hn0232.outbound.protection.outlook.com [104.47.32.232]) by dpdk.org (Postfix) with ESMTP id D7BAD1B395 for ; Wed, 8 Nov 2017 08:17:49 +0100 (CET) Content-Disposition: inline In-Reply-To: <1510121832-16439-1-git-send-email-hejianet@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Wed, 8 Nov 2017 06:17:10 +0000 > From: Jia He > To: jerin.jacob@caviumnetworks.com, dev@dpdk.org, olivier.matz@6wind.com > Cc: konstantin.ananyev@intel.com, bruce.richardson@intel.com, > jianbo.liu@arm.com, hemant.agrawal@nxp.com, Jia He , > jia.he@hxt-semitech.com > Subject: [PATCH 1/3] eal/arm64: remove the braces {} for dmb(),dsb() > X-Mailer: git-send-email 2.7.4 > > for the code as follows: > if (condition) > rte_smp_rmb(); > else > rte_smp_wmb(); > Without this patch, compiler will report this error: > error: 'else' without a previous 'if' > > Signed-off-by: Jia He > Signed-off-by: jia.he@hxt-semitech.com # If both are same person then IMO, one sign-off is enough. # Make sure the patches are ./devtools/checkpatches.sh and ./devtools/check-git-log.sh clean # Add Fixes: tag. Example: http://dpdk.org/ml/archives/dev/2017-November/081510.html