Re: [Qemu-devel] [RFC v3 23/27] qmp: isolate responses into io thread

From: Peter Xu <peterx@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <shajnocz@redhat.com>,
	"Daniel P . Berrange" <berrange@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Jiri Denemark <jdenemar@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	mdroth@linux.vnet.ibm.com, Eric Blake <eblake@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	marcandre.lureau@redhat.com,
	Markus Armbruster <armbru@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [RFC v3 23/27] qmp: isolate responses into io thread
Date: Wed, 8 Nov 2017 15:31:11 +0800	[thread overview]
Message-ID: <20171108073111.GB2992@xz-mi> (raw)
In-Reply-To: <20171107075708.GR16355@lemon>

On Tue, Nov 07, 2017 at 03:57:08PM +0800, Fam Zheng wrote:
> On Mon, 11/06 17:46, Peter Xu wrote:
> > @@ -4294,6 +4366,11 @@ static GMainContext *monitor_io_context_get(void)
> >      return iothread_get_g_main_context(mon_global.mon_iothread);
> >  }
> >  
> > +static AioContext *monitor_aio_context_get(void)
> > +{
> > +    return iothread_get_aio_context(mon_global.mon_iothread);
> > +}
> > +
> 
> This hunk fits better in patch 10, I think?

This function is only used in current patch, so I think it's fine to
put it here.  But sure I can move it into patch 10 as well.

Thanks,

> 
> >  static void monitor_iothread_init(void)
> >  {
> >      mon_global.mon_iothread = iothread_create("monitor_iothread",
> 
> Fam

-- 
Peter Xu