Re: [PATCH] RDMA/bnxt_re: report vlan_id and sl in qp1 recv completion

From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Devesh Sharma
	<devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] RDMA/bnxt_re: report vlan_id and sl in qp1 recv completion
Date: Wed, 8 Nov 2017 09:49:44 +0200	[thread overview]
Message-ID: <20171108074944.GQ18825@mtr-leonro.local> (raw)
In-Reply-To: <VI1PR0502MB3008145309EC3989B23415CED1560-o1MPJYiShExKsLr+rGaxW8DSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

On Wed, Nov 08, 2017 at 06:27:26AM +0000, Parav Pandit wrote:
>
>
> > +static bool bnxt_re_is_vlan_pkt(struct bnxt_qplib_cqe *orig_cqe,
> > +				u16 *vid, u8 *sl)
> > +{
> > +	u32 metadata;
> > +	u16 tpid;
> > +	bool ret = false;
> > +
> Large number of places reverse Christmas tree reverse order is not followed, but let's try to follow for newly added code  like below.
> 	bool ret = false;
> 	u32 metadata;
> 	u16 tpid;

Reversed Christmas tree is a netdev requirement and not other subsystems,
so it a little bit too much to request from the people to do it without
actual updating CodingStyle guide.

I personally require it in our internal reviews to ensure that every
patch can go through netdev if needed (for example shared code) and not
because I like it.

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]