All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Lipeng <lipeng321@huawei.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linuxarm@huawei.com,
	yisen.zhuang@huawei.com, salil.mehta@huawei.com
Subject: Re: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL_config file
Date: Wed, 8 Nov 2017 15:30:52 +0100	[thread overview]
Message-ID: <20171108143052.GH21784@lunn.ch> (raw)
In-Reply-To: <1510127543-34158-2-git-send-email-lipeng321@huawei.com>

On Wed, Nov 08, 2017 at 03:52:22PM +0800, Lipeng wrote:
> From: Fuyun Liang <liangfuyun1@huawei.com>
> 
> Driver gets phy address from NCL_config file and uses the phy address
> to initialize phydev. There are 5 bits for phy address. And C22 phy
> address has 5 bits. So 0-31 are all valid address for phy. If there
> is no phy, it will crash. Because driver always get a valid phy address.

Hi Lipeng

Any plans for C45? The PHY address is still 5 bits, but do you need to
get the device type from your configuration file?

    Andrew

  reply	other threads:[~2017-11-08 14:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08  7:52 [PATCH net-next 0/2] net: hns3: Bug fixes & Code improvements in HNS3 driver Lipeng
2017-11-08  7:52 ` [PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL_config file Lipeng
2017-11-08 14:30   ` Andrew Lunn [this message]
2017-11-08 14:40     ` Salil Mehta
2017-11-09  2:02     ` lipeng (Y)
2017-11-09  3:28       ` Andrew Lunn
2017-11-08  7:52 ` [PATCH net-next 2/2] net: hns3: cleanup mac auto-negotiation state query in hclge_update_speed_duplex Lipeng
2017-11-11  6:20 ` [PATCH net-next 0/2] net: hns3: Bug fixes & Code improvements in HNS3 driver David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171108143052.GH21784@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=lipeng321@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.