From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbdKID3E (ORCPT ); Wed, 8 Nov 2017 22:29:04 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:49154 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbdKID3D (ORCPT ); Wed, 8 Nov 2017 22:29:03 -0500 Date: Thu, 9 Nov 2017 04:28:58 +0100 From: Andrew Lunn To: "lipeng (Y)" Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com Subject: Re: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL_config file Message-ID: <20171109032858.GA1195@lunn.ch> References: <1510127543-34158-1-git-send-email-lipeng321@huawei.com> <1510127543-34158-2-git-send-email-lipeng321@huawei.com> <20171108143052.GH21784@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 09, 2017 at 10:02:37AM +0800, lipeng (Y) wrote: > > > On 2017/11/8 22:30, Andrew Lunn wrote: > >On Wed, Nov 08, 2017 at 03:52:22PM +0800, Lipeng wrote: > >>From: Fuyun Liang > >> > >>Driver gets phy address from NCL_config file and uses the phy address > >>to initialize phydev. There are 5 bits for phy address. And C22 phy > >>address has 5 bits. So 0-31 are all valid address for phy. If there > >>is no phy, it will crash. Because driver always get a valid phy address. > >Hi Lipeng > > > >Any plans for C45? The PHY address is still 5 bits, but do you need to > >get the device type from your configuration file? > > > > Andrew > Hi Andrew > > C45 support is in Plan, now only support C22. > This bugfix patch is valid for C22 and C45. Great. That is all i wanted to know. Thanks Andrew