From: Eryu Guan <eguan@redhat.com>
To: Hou Tao <houtao1@huawei.com>
Cc: fstests@vger.kernel.org, guaneryu@gmail.com,
linux-xfs@vger.kernel.org, darrick.wong@oracle.com,
cmaiolino@redhat.com
Subject: Re: [PATCH v3 1/4] dmflakey: support multiple dm targets for a dm-flakey device
Date: Thu, 9 Nov 2017 16:56:08 +0800 [thread overview]
Message-ID: <20171109085608.GV17339@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20171109073252.36001-2-houtao1@huawei.com>
On Thu, Nov 09, 2017 at 03:32:49PM +0800, Hou Tao wrote:
> dm-flakey can be used to emulate IO write error, however, when
> we also need to prevent the IO error for a specific range of the
> block device (eg., the log region of a XFS), we need to specify
> multiple dm targets for the dm device.
>
> Option --table can not accommodate the multiple dm targets case,
> so let dmsetup get the possible-multiple-targets table from
> standard input.
>
> Signed-off-by: Hou Tao <houtao1@huawei.com>
> ---
> common/dmflakey | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/dmflakey b/common/dmflakey
> index 4434307..16b82d2 100644
> --- a/common/dmflakey
> +++ b/common/dmflakey
> @@ -77,7 +77,7 @@ _load_flakey_table()
> $DMSETUP_PROG suspend $suspend_opt flakey-test
> [ $? -ne 0 ] && _fatal "failed to suspend flakey-test"
>
> - $DMSETUP_PROG load flakey-test --table "$table"
> + echo -e "$table" | $DMSETUP_PROG load flakey-test
Sorry for not bringing this up earlier, but adding some comments would
be good here.
Thanks,
Eryu
> [ $? -ne 0 ] && _fatal "failed to load table into flakey-test"
>
> $DMSETUP_PROG resume flakey-test
> --
> 2.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-09 8:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 7:32 [PATCH v3 0/4] test for XFS umount hang caused by the pending dquota log item in AIL Hou Tao
2017-11-09 7:32 ` [PATCH v3 1/4] dmflakey: support multiple dm targets for a dm-flakey device Hou Tao
2017-11-09 8:56 ` Eryu Guan [this message]
2017-11-09 7:32 ` [PATCH v3 2/4] dmflakey: support error_writes feature for dm-flakey Hou Tao
2017-11-09 8:57 ` Eryu Guan
2017-11-09 7:32 ` [PATCH v3 3/4] xfs: test for umount hang caused by the pending dquota log item in AIL Hou Tao
2017-11-09 9:05 ` Eryu Guan
2017-12-05 0:47 ` Darrick J. Wong
2018-01-10 0:20 ` Darrick J. Wong
2017-11-09 7:32 ` [PATCH v3 4/4] common/rc: factor out _scratch_xfs_[get|set]_sb_field Hou Tao
2017-11-09 17:02 ` Darrick J. Wong
2017-11-09 8:54 ` [PATCH v3 0/4] test for XFS umount hang caused by the pending dquota log item in AIL Eryu Guan
2017-11-21 16:35 ` Carlos Maiolino
2017-11-20 15:13 ` Carlos Maiolino
2017-11-21 15:49 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109085608.GV17339@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=cmaiolino@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=houtao1@huawei.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.