From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2 3/6] drm/i915: Pass crtc_state to ips
 toggle functions
Date: Thu, 9 Nov 2017 19:51:06 +0200
Message-ID: <20171109175106.GY10981@intel.com>
References: <20171109162458.50681-1-maarten.lankhorst@linux.intel.com>
 <20171109162458.50681-3-maarten.lankhorst@linux.intel.com>
 <20171109170957.GV10981@intel.com>
 <d2d1f426-0d07-76cd-e081-cad0a35656e1@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id A49CF6E959
 for <intel-gfx@lists.freedesktop.org>; Thu,  9 Nov 2017 17:51:10 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <d2d1f426-0d07-76cd-e081-cad0a35656e1@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBOb3YgMDksIDIwMTcgYXQgMDY6MzE6MDJQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y
c3Qgd3JvdGU6Cj4gT3AgMDktMTEtMTcgb20gMTg6MDkgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6
Cj4gPiBPbiBUaHUsIE5vdiAwOSwgMjAxNyBhdCAwNToyNDo1NVBNICswMTAwLCBNYWFydGVuIExh
bmtob3JzdCB3cm90ZToKPiA+PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFh
cnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ID4+IC0tLQo+ID4+ICBkcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jICAgfCAgNCArKy0tCj4gPj4gIGRyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDI0ICsrKysrKysrKysrKystLS0tLS0tLS0tLQo+ID4+
ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICAgICAgfCAgNiArKystLS0KPiA+PiAg
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgIDQgKystLQo+ID4+ICA0IGZp
bGVzIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4g
ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gPj4gaW5kZXggYjgzMTViY2E4NTJiLi5jNjM3
M2ZlYmY2MTcgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29s
b3IuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMKPiA+PiBA
QCAtMzcwLDcgKzM3MCw3IEBAIHN0YXRpYyB2b2lkIGhhc3dlbGxfbG9hZF9sdXRzKHN0cnVjdCBk
cm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiA+PiAgCSAqLwo+ID4+ICAJaWYgKElTX0hBU1dF
TEwoZGV2X3ByaXYpICYmIGludGVsX2NydGNfc3RhdGUtPmlwc19lbmFibGVkICYmCj4gPj4gIAkg
ICAgKGludGVsX2NydGNfc3RhdGUtPmdhbW1hX21vZGUgPT0gR0FNTUFfTU9ERV9NT0RFX1NQTElU
KSkgewo+ID4+IC0JCWhzd19kaXNhYmxlX2lwcyhpbnRlbF9jcnRjKTsKPiA+PiArCQloc3dfZGlz
YWJsZV9pcHMoaW50ZWxfY3J0YywgaW50ZWxfY3J0Y19zdGF0ZSk7Cj4gPiBJIHdvdWxkIHN1Z2dl
c3Qgc2ltcGxpZnlpbmcgbW9yZSBhbmQgcGFzc2luZyBvbmx5IHRoZSBzdGF0ZS4KPiA+IFRoZSBj
YWxsZWUgY2FuIGFsd2F5cyBkaWcgb3V0IHRoZSBjcnRjIGlmIGl0IG5lZWRzIGl0Lgo+ID4KPiA+
PiAgCQlyZWVuYWJsZV9pcHMgPSB0cnVlOwo+ID4+ICAJfQo+ID4+ICAKPiA+PiBAQCAtMzgwLDcg
KzM4MCw3IEBAIHN0YXRpYyB2b2lkIGhhc3dlbGxfbG9hZF9sdXRzKHN0cnVjdCBkcm1fY3J0Y19z
dGF0ZSAqY3J0Y19zdGF0ZSkKPiA+PiAgCWk5eHhfbG9hZF9sdXRzKGNydGNfc3RhdGUpOwo+ID4+
ICAKPiA+PiAgCWlmIChyZWVuYWJsZV9pcHMpCj4gPj4gLQkJaHN3X2VuYWJsZV9pcHMoaW50ZWxf
Y3J0Yyk7Cj4gPj4gKwkJaHN3X2VuYWJsZV9pcHMoaW50ZWxfY3J0YywgaW50ZWxfY3J0Y19zdGF0
ZSk7Cj4gPj4gIH0KPiA+PiAgCj4gPj4gIHN0YXRpYyB2b2lkIGJkd19sb2FkX2RlZ2FtbWFfbHV0
KHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUpCj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X2Rpc3BsYXkuYwo+ID4+IGluZGV4IGY1OTMzYjA3MTljOS4uMTNiMzcyZTRmMDZlIDEwMDY0NAo+
ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4+ICsrKyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4+IEBAIC00ODMyLDEyICs0
ODMyLDEyIEBAIHN0YXRpYyB2b2lkIGlyb25sYWtlX3BmaXRfZW5hYmxlKHN0cnVjdCBpbnRlbF9j
cnRjICpjcnRjKQo+ID4+ICAJfQo+ID4+ICB9Cj4gPj4gIAo+ID4+IC12b2lkIGhzd19lbmFibGVf
aXBzKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ID4+ICt2b2lkIGhzd19lbmFibGVfaXBzKHN0
cnVjdCBpbnRlbF9jcnRjICpjcnRjLCBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0
Y19zdGF0ZSkKPiA+PiAgewo+ID4+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmJh
c2UuZGV2Owo+ID4+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx
NShkZXYpOwo+ID4+ICAKPiA+PiAtCWlmICghY3J0Yy0+Y29uZmlnLT5pcHNfZW5hYmxlZCkKPiA+
PiArCWlmICghY3J0Y19zdGF0ZS0+aXBzX2VuYWJsZWQpCj4gPj4gIAkJcmV0dXJuOwo+ID4+ICAK
PiA+PiAgCS8qCj4gPj4gQEAgLTQ4NzEsMTIgKzQ4NzEsMTIgQEAgdm9pZCBoc3dfZW5hYmxlX2lw
cyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiA+PiAgCX0KPiA+PiAgfQo+ID4+ICAKPiA+PiAt
dm9pZCBoc3dfZGlzYWJsZV9pcHMoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gPj4gK3ZvaWQg
aHN3X2Rpc2FibGVfaXBzKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLCBjb25zdCBzdHJ1Y3QgaW50
ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiA+PiAgewo+ID4+ICAJc3RydWN0IGRybV9kZXZp
Y2UgKmRldiA9IGNydGMtPmJhc2UuZGV2Owo+ID4+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg
KmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ID4+ICAKPiA+PiAtCWlmICghY3J0Yy0+Y29uZmln
LT5pcHNfZW5hYmxlZCkKPiA+PiArCWlmICghY3J0Y19zdGF0ZS0+aXBzX2VuYWJsZWQpCj4gPj4g
IAkJcmV0dXJuOwo+ID4+ICAKPiA+PiAgCWFzc2VydF9wbGFuZV9lbmFibGVkKGRldl9wcml2LCBj
cnRjLT5wbGFuZSk7Cj4gPiBIbW0uIENvbmZ1c2llZC4gT2ggcmlnaHQsIG15IHBsYW5lIGFzc2Vy
dCBjbGVhbnVwIGRpZG4ndCBtYW5hZ2UgdG8gZ28gaW4geWV0IDpQCj4gPgo+ID4+IEBAIC00OTI0
LDcgKzQ5MjQsOCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9jcnRjX2RwbXNfb3ZlcmxheV9kaXNhYmxl
KHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjKQo+ID4+ICAgKiBjb21wbGV0ZWx5IGhpZGUg
dGhlIHByaW1hcnkgcGxhbmUuCj4gPj4gICAqLwo+ID4+ICBzdGF0aWMgdm9pZAo+ID4+IC1pbnRl
bF9wb3N0X2VuYWJsZV9wcmltYXJ5KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiA+PiAraW50ZWxf
cG9zdF9lbmFibGVfcHJpbWFyeShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gPj4gKwkJCSAgY29u
c3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlKQo+ID4+ICB7Cj4gPj4g
IAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+ZGV2Owo+ID4+ICAJc3RydWN0IGRybV9p
OTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ID4+IEBAIC00OTM3LDcgKzQ5
MzgsNyBAQCBpbnRlbF9wb3N0X2VuYWJsZV9wcmltYXJ5KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykK
PiA+PiAgCSAqIHdoZW4gZ29pbmcgZnJvbSBwcmltYXJ5IG9ubHkgdG8gc3ByaXRlIG9ubHkgYW5k
IHZpY2UKPiA+PiAgCSAqIHZlcnNhLgo+ID4+ICAJICovCj4gPj4gLQloc3dfZW5hYmxlX2lwcyhp
bnRlbF9jcnRjKTsKPiA+PiArCWhzd19lbmFibGVfaXBzKGludGVsX2NydGMsIG5ld19jcnRjX3N0
YXRlKTsKPiA+PiAgCj4gPj4gIAkvKgo+ID4+ICAJICogR2VuMiByZXBvcnRzIHBpcGUgdW5kZXJy
dW5zIHdoZW5ldmVyIGFsbCBwbGFuZXMgYXJlIGRpc2FibGVkLgo+ID4+IEBAIC00OTU2LDcgKzQ5
NTcsOCBAQCBpbnRlbF9wb3N0X2VuYWJsZV9wcmltYXJ5KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykK
PiA+PiAgCj4gPj4gIC8qIEZJWE1FIG1vdmUgYWxsIHRoaXMgdG8gcHJlX3BsYW5lX3VwZGF0ZSgp
IHdpdGggcHJvcGVyIHN0YXRlIHRyYWNraW5nICovCj4gPj4gIHN0YXRpYyB2b2lkCj4gPj4gLWlu
dGVsX3ByZV9kaXNhYmxlX3ByaW1hcnkoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ID4+ICtpbnRl
bF9wcmVfZGlzYWJsZV9wcmltYXJ5KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiA+PiArCQkJICBj
b25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUpCj4gPj4gIHsKPiA+
PiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5kZXY7Cj4gPj4gIAlzdHJ1Y3QgZHJt
X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gPj4gQEAgLTQ5NzgsNyAr
NDk4MCw3IEBAIGludGVsX3ByZV9kaXNhYmxlX3ByaW1hcnkoc3RydWN0IGRybV9jcnRjICpjcnRj
KQo+ID4+ICAJICogd2hlbiBnb2luZyBmcm9tIHByaW1hcnkgb25seSB0byBzcHJpdGUgb25seSBh
bmQgdmljZQo+ID4+ICAJICogdmVyc2EuCj4gPj4gIAkgKi8KPiA+PiAtCWhzd19kaXNhYmxlX2lw
cyhpbnRlbF9jcnRjKTsKPiA+PiArCWhzd19kaXNhYmxlX2lwcyhpbnRlbF9jcnRjLCBvbGRfY3J0
Y19zdGF0ZSk7Cj4gPj4gIH0KPiA+PiAgCj4gPj4gIC8qIEZJWE1FIGdldCByaWQgb2YgdGhpcyBh
bmQgdXNlIHByZV9wbGFuZV91cGRhdGUgKi8KPiA+PiBAQCAtNDk5MCw3ICs0OTkyLDcgQEAgaW50
ZWxfcHJlX2Rpc2FibGVfcHJpbWFyeV9ub2F0b21pYyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4g
Pj4gIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMoY3J0Yyk7
Cj4gPj4gIAlpbnQgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4gPj4gIAo+ID4+IC0JaW50ZWxf
cHJlX2Rpc2FibGVfcHJpbWFyeShjcnRjKTsKPiA+PiArCWludGVsX3ByZV9kaXNhYmxlX3ByaW1h
cnkoY3J0YywgdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjLT5zdGF0ZSkpOwo+ID4+ICAKPiA+PiAg
CS8qCj4gPj4gIAkgKiBWYmxhbmsgdGltZSB1cGRhdGVzIGZyb20gdGhlIHNoYWRvdyB0byBsaXZl
IHBsYW5lIGNvbnRyb2wgcmVnaXN0ZXIKPiA+PiBAQCAtNTAzNCw3ICs1MDM2LDcgQEAgc3RhdGlj
IHZvaWQgaW50ZWxfcG9zdF9wbGFuZV91cGRhdGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9s
ZF9jcnRjX3N0YXRlKQo+ID4+ICAJCWlmIChwcmltYXJ5X3N0YXRlLT5iYXNlLnZpc2libGUgJiYK
PiA+PiAgCQkgICAgKG5lZWRzX21vZGVzZXQoJnBpcGVfY29uZmlnLT5iYXNlKSB8fAo+ID4+ICAJ
CSAgICAgIW9sZF9wcmltYXJ5X3N0YXRlLT5iYXNlLnZpc2libGUpKQo+ID4+IC0JCQlpbnRlbF9w
b3N0X2VuYWJsZV9wcmltYXJ5KCZjcnRjLT5iYXNlKTsKPiA+PiArCQkJaW50ZWxfcG9zdF9lbmFi
bGVfcHJpbWFyeSgmY3J0Yy0+YmFzZSwgcGlwZV9jb25maWcpOwo+ID4+ICAJfQo+ID4+ICB9Cj4g
Pj4gIAo+ID4+IEBAIC01MDYzLDcgKzUwNjUsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9wcmVfcGxh
bmVfdXBkYXRlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSwKPiA+PiAg
Cj4gPj4gIAkJaWYgKG9sZF9wcmltYXJ5X3N0YXRlLT5iYXNlLnZpc2libGUgJiYKPiA+PiAgCQkg
ICAgKG1vZGVzZXQgfHwgIXByaW1hcnlfc3RhdGUtPmJhc2UudmlzaWJsZSkpCj4gPj4gLQkJCWlu
dGVsX3ByZV9kaXNhYmxlX3ByaW1hcnkoJmNydGMtPmJhc2UpOwo+ID4+ICsJCQlpbnRlbF9wcmVf
ZGlzYWJsZV9wcmltYXJ5KCZjcnRjLT5iYXNlLCBvbGRfY3J0Y19zdGF0ZSk7Cj4gPj4gIAl9Cj4g
Pj4gIAo+ID4+ICAJLyoKPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+PiBpbmRleCBjZGRk
OTZiMjQ4NzguLjgyYzMzZDljZDQ2NiAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9kcC5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAu
Ywo+ID4+IEBAIC0zOTQ3LDcgKzM5NDcsNyBAQCBzdGF0aWMgaW50IGludGVsX2RwX3NpbmtfY3Jj
X3N0b3Aoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiA+PiAgCX0KPiA+PiAgCj4gPj4gICBv
dXQ6Cj4gPj4gLQloc3dfZW5hYmxlX2lwcyhpbnRlbF9jcnRjKTsKPiA+PiArCWhzd19lbmFibGVf
aXBzKGludGVsX2NydGMsIHRvX2ludGVsX2NydGNfc3RhdGUoaW50ZWxfY3J0Yy0+YmFzZS5zdGF0
ZSkpOwo+ID4gY3J0Yy0+Y29uZmlnIHdvdWxkIHNlZW0gbGlrZSB0aGUgc2xpZ2h0bHkgbW9yZSBj
b3JyZWN0IHRoaW5nIHRvIHBhc3MKPiA+IGhlcmUuIEl0J3MgYWxzbyBlYXNpZXIgdG8gZ3JlcCBm
b3Igd2hlbiBzb21lb25lIHNldHMgb3V0IHRvIGZpeCB0aGlzCj4gPiBtZXNzIHByb3Blcmx5Lgo+
IENvbnNpZGVyZWQgaXQsIGJ1dCBvdXIgY3J0Yy0+Y29uZmlnIHVzYWdlIGlzIGEgbWVzcy4gSSdk
IHJhdGhlciBnZXQgcmlkIG9mIHRoZSBpbnRlbF9kcF9zaW5rX2NyYyBjb2RlIHRiaC4gOi8KCkkn
ZCByYXRoZXIgbm90IHNwcmVhZCBtb3JlIC0+c3RhdGUgdXNlcyB3aGVuIEkganVzdCByZWNlbnRs
eQptYW5hZ2VkIHRvIGNsZWFuIG91dCBtYW55IG9mIHRoZW0uIFdlIHN0aWxsIGhhdmUgc29tZSBs
ZWZ0IGZvcgpzdXJlLCBidXQgYWRkaW5nIG1vcmUgc2VlbXMgbGlrZSBnb2luZyBiYWNrd2FyZHMu
CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs
aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h
bi9saXN0aW5mby9pbnRlbC1nZngK