From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755976AbdKJEtJ (ORCPT ); Thu, 9 Nov 2017 23:49:09 -0500 Received: from mga11.intel.com ([192.55.52.93]:23920 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755871AbdKJEtI (ORCPT ); Thu, 9 Nov 2017 23:49:08 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,372,1505804400"; d="scan'208";a="171930340" Date: Fri, 10 Nov 2017 10:22:19 +0530 From: Vinod Koul To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , LKML , ALSA , Mark , Takashi , Pierre , Sanyog Kale , Shreyas NC , patches.audio@intel.com, alan@linux.intel.com, Charles Keepax , Sagar Dharia , plai@codeaurora.org, Sudheer Papothi Subject: Re: [PATCH 10/14] soundwire: Add sysfs for SoundWire DisCo properties Message-ID: <20171110045219.GK3187@localhost> References: <1508382211-3154-1-git-send-email-vinod.koul@intel.com> <1508382211-3154-11-git-send-email-vinod.koul@intel.com> <1e82021b-a721-b0a3-6586-cee0077f865a@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1e82021b-a721-b0a3-6586-cee0077f865a@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 09, 2017 at 09:14:35PM +0000, Srinivas Kandagatla wrote: > > > On 19/10/17 04:03, Vinod Koul wrote: > >It helps to read the properties for understanding and debug > >SoundWire systems, so add sysfs files for SoundWire DisCo > >properties. > > > >TODO: Add ABI files for sysfs > > > >Signed-off-by: Sanyog Kale > >Signed-off-by: Vinod Koul > >--- > > >diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c > >index 6c4f41b64744..e3d7aea18892 100644 > >--- a/drivers/soundwire/bus.c > >+++ b/drivers/soundwire/bus.c > >@@ -90,6 +90,8 @@ int sdw_add_bus_master(struct sdw_bus *bus) > > } > > } > >+ sdw_sysfs_bus_init(bus); > >+ > > /* > > * SDW is an enumerable bus, but devices can be powered off. So, > > * they won't be able to report as present. > >@@ -119,6 +121,8 @@ static int sdw_delete_slave(struct device *dev, void *data) > > struct sdw_slave *slave = dev_to_sdw_dev(dev); > > struct sdw_bus *bus = slave->bus; > >+ sdw_sysfs_slave_exit(slave); > >+ > > mutex_lock(&bus->bus_lock); > > if (!list_empty(&bus->slaves)) > > list_del(&slave->node); > >@@ -130,6 +134,7 @@ static int sdw_delete_slave(struct device *dev, void *data) > > void sdw_delete_bus_master(struct sdw_bus *bus) > > { > >+ sdw_sysfs_bus_init(bus); > > Shouldn't this be sdw_sysfs_bus_exit() here? yes thats right, fixes in for v2 -- ~Vinod