All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raphael Hertzog <raphael@ouaza.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH] ovl: fix failure to fsync lower dir
Date: Fri, 10 Nov 2017 10:10:18 +0100	[thread overview]
Message-ID: <20171110091018.tonnsn2yut4byk2q@home.ouaza.com> (raw)
In-Reply-To: <1510126786-16044-1-git-send-email-amir73il@gmail.com>

Hi Amir,

Le mercredi 08 novembre 2017, Amir Goldstein a écrit :
> The problem reported by Raphael is that new PostgreSQL 10.0 with a
> database in overlayfs where lower layer in squashfs fails to start.
> The failure is due to fsync error, when PostgreSQL does fsync on all
> existing db directories on startup and a specific directory exists
> lower layer with no changes.

I confirm that this patch is enough to fix my issue.

Tested-by: Raphaël Hertzog <hertzog@debian.org>

I wonder if we can have a similar problem with a file. Is it possible to
fsync a file opened in read-only mode? Even if it's possible, I assume
this is really rare.

And when you open a file with read-write permissions, when does the
copy-up happen? If it's immediately, then fsync on such a file is safe as
well.

Cheers,
-- 
Raphaël Hertzog ◈ Writer/Consultant ◈ Debian Developer

Discover the Debian Administrator's Handbook:
→ https://debian-handbook.info/get/

  reply	other threads:[~2017-11-10  9:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08  7:39 [PATCH] ovl: fix failure to fsync lower dir Amir Goldstein
2017-11-10  9:10 ` Raphael Hertzog [this message]
2017-11-10  9:14   ` Amir Goldstein
2017-11-22  5:44   ` Amir Goldstein
2017-11-22  9:33     ` Miklos Szeredi
2017-11-22 12:19       ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171110091018.tonnsn2yut4byk2q@home.ouaza.com \
    --to=raphael@ouaza.com \
    --cc=amir73il@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.