All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [CI 5/8] drm/i915: Inline intel_modeset_gem_init()
Date: Fri, 10 Nov 2017 14:26:31 +0000	[thread overview]
Message-ID: <20171110142634.10551-5-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20171110142634.10551-1-chris@chris-wilson.co.uk>

intel_modeset_gem_init() now only sets up the legacy overlay, so let's
remove the function and call the setup directly during driver load. This
should help us find a better point in the initialisation sequence for it
later.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c      | 2 +-
 drivers/gpu/drm/i915/i915_drv.h      | 1 -
 drivers/gpu/drm/i915/intel_display.c | 7 -------
 3 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index e7e9e061073b..1b440f2b90a5 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -676,7 +676,7 @@ static int i915_load_modeset_init(struct drm_device *dev)
 	if (ret)
 		goto cleanup_uc;
 
-	intel_modeset_gem_init(dev);
+	intel_setup_overlay(dev_priv);
 
 	if (INTEL_INFO(dev_priv)->num_pipes == 0)
 		return 0;
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index c94f34f5cee3..0be9a918697a 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -4124,7 +4124,6 @@ void intel_device_info_dump(struct drm_i915_private *dev_priv);
 /* modesetting */
 extern void intel_modeset_init_hw(struct drm_device *dev);
 extern int intel_modeset_init(struct drm_device *dev);
-extern void intel_modeset_gem_init(struct drm_device *dev);
 extern void intel_modeset_cleanup(struct drm_device *dev);
 extern int intel_connector_register(struct drm_connector *);
 extern void intel_connector_unregister(struct drm_connector *);
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 63cc09ade9d1..5c7540f3f5dc 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -15194,13 +15194,6 @@ void intel_display_resume(struct drm_device *dev)
 		drm_atomic_state_put(state);
 }
 
-void intel_modeset_gem_init(struct drm_device *dev)
-{
-	struct drm_i915_private *dev_priv = to_i915(dev);
-
-	intel_setup_overlay(dev_priv);
-}
-
 int intel_connector_register(struct drm_connector *connector)
 {
 	struct intel_connector *intel_connector = to_intel_connector(connector);
-- 
2.15.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-11-10 14:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-10 14:26 [CI 1/8] drm/i915: Define an engine class enum for the uABI Chris Wilson
2017-11-10 14:26 ` [CI 2/8] drm/i915: Force the switch to the i915->kernel_context Chris Wilson
2017-11-10 14:26 ` [CI 3/8] drm/i915: Move GT powersaving init to i915_gem_init() Chris Wilson
2017-11-10 14:26 ` [CI 4/8] drm/i915: Move intel_init_clock_gating() " Chris Wilson
2017-11-10 14:26 ` Chris Wilson [this message]
2017-11-10 14:26 ` [CI 6/8] drm/i915: Mark the context state as dirty/written Chris Wilson
2017-11-10 14:26 ` [CI 7/8] drm/i915: Record the default hw state after reset upon load Chris Wilson
2017-11-10 14:26 ` [CI 8/8] drm/i915: Stop caching the "golden" renderstate Chris Wilson
2017-11-10 14:45 ` ✓ Fi.CI.BAT: success for series starting with [CI,1/8] drm/i915: Define an engine class enum for the uABI Patchwork
2017-11-10 16:46 ` ✓ Fi.CI.IGT: " Patchwork
2017-11-10 18:14   ` Chris Wilson
2018-01-24 23:01     ` Jeff McGee
2018-01-25 12:04       ` Chris Wilson
  -- strict thread matches above, loose matches on Subject: below --
2017-11-06 13:28 [CI 1/8] drm/i915: Assert guc->stage_desc_pool is allocated Chris Wilson
2017-11-06 13:28 ` [CI 5/8] drm/i915: Inline intel_modeset_gem_init() Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171110142634.10551-5-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.