From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ladislav Michl Subject: Re: [PATCH v3 5/7] mtd: onenand: omap2: Unify OMAP2 and OMAP3 DMA implementation Date: Fri, 10 Nov 2017 19:19:51 +0100 Message-ID: <20171110181951.siddrdubjkwwspqt@lenoch> References: <20171109091155.6a6azfvjarwvlfh2@lenoch> <20171109091529.x3pqqvbiywj5aulo@lenoch> <4a58dfac-8cc9-101f-b079-da8925d7ab4c@ti.com> <20171110095154.kf34cd7h2eyfvwf3@lenoch> <20171110152610.GN28152@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20171110152610.GN28152@atomide.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: Tony Lindgren Cc: Boris Brezillon , Kyungmin Park , linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, Roger Quadros List-Id: linux-omap@vger.kernel.org On Fri, Nov 10, 2017 at 07:26:10AM -0800, Tony Lindgren wrote: > * Ladislav Michl [171110 09:53]: > > On Fri, Nov 10, 2017 at 10:21:51AM +0200, Roger Quadros wrote: > > > On 09/11/17 11:15, Ladislav Michl wrote: > > > > Since the very first commit (36cd4fb5d277: "[MTD] [OneNAND] Add OMAP2 / OMAP3 > > > > OneNAND driver") DMA is disabled for OMAP2. Later fixes thus went only into > > > > OMAP3 specific DMA functions which turned out not to be so OMAP3 specific. > > > > Therefore replace open coded timeout waiting for completion in OMAP3 > > > > functions with API call and merge those two implementations. > > > > > > > > Note that currently the is no single DMA user, so this change is basically > > > > no-op. Those interested will have to find DMA configuration in the > > > > linux-omap.git history. > > > > > > > > Signed-off-by: Ladislav Michl > > > > > > I'll be happy if there are no OMAP2 vs OMAP3 differences in code but we need to > > > be absolutely sure that we don't break DMA functionality if it ever worked. > > > > It probably worked at least for OMAP3 as it was enabled in legacy kernels. > > > > > Can we somehow test OneNAND DMA on OMAP2 and OMAP3? > > > Tony? > > > > I'll prepare next version patch serie for easier testing. Of course I would > > prefer to be able to test changes myself, but I do not have any Nokias :-) > > I tested Peter's dma changes yesterday and they worked. Yeah if you want > me to test something a complete series or a git branch makes it easier > for me to follow what all is needed. How did you configure DMA? Is there any additional patch? So far I prepared complete patchset including Peter's changes, but I might be good idea to start with something what's working for you. Thanks, ladis ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eddie.linux-mips.org ([148.251.95.138] helo=cvs.linux-mips.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eDDum-0008Ap-7P for linux-mtd@lists.infradead.org; Fri, 10 Nov 2017 18:20:30 +0000 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23992309AbdKJSUBlw6KP (ORCPT ); Fri, 10 Nov 2017 19:20:01 +0100 Date: Fri, 10 Nov 2017 19:19:51 +0100 Sender: Ladislav Michl From: Ladislav Michl To: Tony Lindgren Cc: Roger Quadros , linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, Boris Brezillon , Kyungmin Park Subject: Re: [PATCH v3 5/7] mtd: onenand: omap2: Unify OMAP2 and OMAP3 DMA implementation Message-ID: <20171110181951.siddrdubjkwwspqt@lenoch> References: <20171109091155.6a6azfvjarwvlfh2@lenoch> <20171109091529.x3pqqvbiywj5aulo@lenoch> <4a58dfac-8cc9-101f-b079-da8925d7ab4c@ti.com> <20171110095154.kf34cd7h2eyfvwf3@lenoch> <20171110152610.GN28152@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171110152610.GN28152@atomide.com> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Nov 10, 2017 at 07:26:10AM -0800, Tony Lindgren wrote: > * Ladislav Michl [171110 09:53]: > > On Fri, Nov 10, 2017 at 10:21:51AM +0200, Roger Quadros wrote: > > > On 09/11/17 11:15, Ladislav Michl wrote: > > > > Since the very first commit (36cd4fb5d277: "[MTD] [OneNAND] Add OMAP2 / OMAP3 > > > > OneNAND driver") DMA is disabled for OMAP2. Later fixes thus went only into > > > > OMAP3 specific DMA functions which turned out not to be so OMAP3 specific. > > > > Therefore replace open coded timeout waiting for completion in OMAP3 > > > > functions with API call and merge those two implementations. > > > > > > > > Note that currently the is no single DMA user, so this change is basically > > > > no-op. Those interested will have to find DMA configuration in the > > > > linux-omap.git history. > > > > > > > > Signed-off-by: Ladislav Michl > > > > > > I'll be happy if there are no OMAP2 vs OMAP3 differences in code but we need to > > > be absolutely sure that we don't break DMA functionality if it ever worked. > > > > It probably worked at least for OMAP3 as it was enabled in legacy kernels. > > > > > Can we somehow test OneNAND DMA on OMAP2 and OMAP3? > > > Tony? > > > > I'll prepare next version patch serie for easier testing. Of course I would > > prefer to be able to test changes myself, but I do not have any Nokias :-) > > I tested Peter's dma changes yesterday and they worked. Yeah if you want > me to test something a complete series or a git branch makes it easier > for me to follow what all is needed. How did you configure DMA? Is there any additional patch? So far I prepared complete patchset including Peter's changes, but I might be good idea to start with something what's working for you. Thanks, ladis