From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753768AbdKKLvT (ORCPT ); Sat, 11 Nov 2017 06:51:19 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:33968 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751640AbdKKLvO (ORCPT ); Sat, 11 Nov 2017 06:51:14 -0500 From: Colin King To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Monk Liu , Xiangliang Yu , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Date: Sat, 11 Nov 2017 11:51:10 +0000 Message-Id: <20171111115110.3026-1-colin.king@canonical.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed. Cleans up clang warning: drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c index 6738df836a70..b1cc179512fa 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c @@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj, void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) { - uint32_t pf2vf_ver = 0; uint32_t pf2vf_size = 0; uint32_t checksum = 0; uint32_t checkval; @@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) adev->virt.fw_reserve.p_pf2vf = (struct amdgim_pf2vf_info_header *)( adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET); - pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version; AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size); AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum); -- 2.14.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin King Date: Sat, 11 Nov 2017 11:51:10 +0000 Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Message-Id: <20171111115110.3026-1-colin.king@canonical.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Monk Liu , Xiangliang Yu , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Colin Ian King Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed. Cleans up clang warning: drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c index 6738df836a70..b1cc179512fa 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c @@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj, void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) { - uint32_t pf2vf_ver = 0; uint32_t pf2vf_size = 0; uint32_t checksum = 0; uint32_t checkval; @@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) adev->virt.fw_reserve.p_pf2vf (struct amdgim_pf2vf_info_header *)( adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET); - pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version; AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size); AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum); -- 2.14.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin King Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Date: Sat, 11 Nov 2017 11:51:10 +0000 Message-ID: <20171111115110.3026-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Monk Liu , Xiangliang Yu , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org RnJvbTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4KClZhcmlhYmxl IHBmMnZmX3ZlciBpcyBhc3NpZ25lZCBidXQgbmV2ZXIgcmVhZCwgaXQgaXMgcmVkdW5kYW50IGFu ZApoZW5jZSBjYW4gYmUgcmVtb3ZlZC4KCkNsZWFucyB1cCBjbGFuZyB3YXJuaW5nOgpkcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdmlydC5jOjMxMDozOiB3YXJuaW5nOiBWYWx1ZSBz dG9yZWQKdG8gJ3BmMnZmX3ZlcicgaXMgbmV2ZXIgcmVhZAoKU2lnbmVkLW9mZi1ieTogQ29saW4g SWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfdmlydC5jIHwgMiAtLQogMSBmaWxlIGNoYW5nZWQsIDIgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3Zp cnQuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92aXJ0LmMKaW5kZXggNjcz OGRmODM2YTcwLi5iMWNjMTc5NTEyZmEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV92aXJ0LmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X3ZpcnQuYwpAQCAtMjk2LDcgKzI5Niw2IEBAIGludCBhbWRncHVfdmlydF9md19yZXNlcnZl X2dldF9jaGVja3N1bSh2b2lkICpvYmosCiAKIHZvaWQgYW1kZ3B1X3ZpcnRfaW5pdF9kYXRhX2V4 Y2hhbmdlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQogewotCXVpbnQzMl90IHBmMnZmX3Zl ciA9IDA7CiAJdWludDMyX3QgcGYydmZfc2l6ZSA9IDA7CiAJdWludDMyX3QgY2hlY2tzdW0gPSAw OwogCXVpbnQzMl90IGNoZWNrdmFsOwpAQCAtMzA5LDcgKzMwOCw2IEBAIHZvaWQgYW1kZ3B1X3Zp cnRfaW5pdF9kYXRhX2V4Y2hhbmdlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQogCQlhZGV2 LT52aXJ0LmZ3X3Jlc2VydmUucF9wZjJ2ZiA9CiAJCQkoc3RydWN0IGFtZGdpbV9wZjJ2Zl9pbmZv X2hlYWRlciAqKSgKIAkJCWFkZXYtPmZ3X3ZyYW1fdXNhZ2UudmEgKyBBTURHSU1fREFUQUVYQ0hB TkdFX09GRlNFVCk7Ci0JCXBmMnZmX3ZlciA9IGFkZXYtPnZpcnQuZndfcmVzZXJ2ZS5wX3BmMnZm LT52ZXJzaW9uOwogCQlBTURHUFVfRldfVlJBTV9QRjJWRl9SRUFEKGFkZXYsIGhlYWRlci5zaXpl LCAmcGYydmZfc2l6ZSk7CiAJCUFNREdQVV9GV19WUkFNX1BGMlZGX1JFQUQoYWRldiwgY2hlY2tz dW0sICZjaGVja3N1bSk7CiAKLS0gCjIuMTQuMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg==