From: Stephen Hemminger <stephen@networkplumber.org>
To: David Miller <davem@davemloft.net>
Cc: edumazet@google.com, netdev@vger.kernel.org, sthemmin@microsoft.com
Subject: Re: [PATCH net-next] tcp: Namespace-ify sysctl_tcp_default_congestion_control
Date: Mon, 13 Nov 2017 07:37:38 -0800 [thread overview]
Message-ID: <20171113073738.6b405d77@xeon-e3> (raw)
In-Reply-To: <20171113.102700.2072956247690538502.davem@davemloft.net>
On Mon, 13 Nov 2017 10:27:00 +0900 (KST)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> Date: Fri, 10 Nov 2017 10:26:37 +0900
>
> > Make default TCP default congestion control to a per namespace
> > value. The congestion control setting of new namespaces is inherited
> > from the root namespace. Modules are only autoloaded in the root namespace.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> I have to think some more about this and the semantics you've choosen.
>
> Is it really buying us anything to restrict the module load to the
> initial namespace? Unless it's really required this makes things like
> running tests in sub-namespaces unnecessarily cumbersome.
The motivation for this came from Eric Dumazet who has tests that
run in namespaces, and doing a per-namespace setup is good way to control
the default congestion control.
The restriction came from earlier discussion with Kees and Eric.
The security folks are paranoid about containers allowing loading
of modules. Probably CAP_SYS_MODULE is enough to control this already.
next prev parent reply other threads:[~2017-11-13 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 1:26 [PATCH net-next] tcp: Namespace-ify sysctl_tcp_default_congestion_control Stephen Hemminger
2017-11-13 1:27 ` David Miller
2017-11-13 15:37 ` Stephen Hemminger [this message]
2017-11-14 12:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113073738.6b405d77@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.