From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752284AbdKMJQ2 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Nov 2017 04:16:28 -0500
Received: from mail-lf0-f53.google.com ([209.85.215.53]:48777 "EHLO
        mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751587AbdKMJQZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Nov 2017 04:16:25 -0500
X-Google-Smtp-Source: AGs4zMYLrIZbdCYBO2ezLn/guxVOmicM0xnisX1mzIBjF1ZuS7QU7ryWc7eY3AhO9/Iyj8Z9o+6vMQ==
Date: Mon, 13 Nov 2017 10:16:29 +0100
From: Johan Hovold <johan@kernel.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Johan Hovold <johan@kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable <stable@vger.kernel.org>,
        Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [PATCH 2/3] Input: twl6040-vibra: fix child-node lookup
Message-ID: <20171113091629.GQ11226@localhost>
References: <20171111154339.16875-1-johan@kernel.org>
 <20171111154339.16875-2-johan@kernel.org>
 <91A591C4-D6BD-462D-B81E-224DB268EDDB@goldelico.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <91A591C4-D6BD-462D-B81E-224DB268EDDB@goldelico.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 13, 2017 at 08:30:53AM +0100, H. Nikolaus Schaller wrote:
> Hi Johan,
> 
> > Am 11.11.2017 um 16:43 schrieb Johan Hovold <johan@kernel.org>:
> > 
> > Fix child-node lookup during probe, which ended up searching the whole
> > device tree depth-first starting at parent rather than just matching on
> > its children.
> > 
> > Later sanity checks on node properties (which would likely be missing)
> > should prevent this from causing much trouble however, especially as the
> > original premature free of the parent node has already been fixed
> > separately (but that "fix" was apparently never backported to stable).
> > 
> > Fixes: e7ec014a47e4 ("Input: twl6040-vibra - update for device tree support")
> > Fixes: c52c545ead97 ("Input: twl6040-vibra - fix DT node memory management")
> > Cc: stable <stable@vger.kernel.org>     # 3.6
> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > Cc: H. Nikolaus Schaller <hns@goldelico.com>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> 
> Tested-By: H. Nikolaus Schaller <hns@goldelico.com>	(on Pyra OMAP5 hardware)
> 
> I also tested your twl4030-vibra patch on GTA04.
> 
> No regressions observed.

Thanks for testing.

Johan