From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752749AbdKMLwj (ORCPT ); Mon, 13 Nov 2017 06:52:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42158 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493AbdKMLwh (ORCPT ); Mon, 13 Nov 2017 06:52:37 -0500 Date: Mon, 13 Nov 2017 12:52:34 +0100 From: Jiri Olsa To: Wang Nan Cc: linux-kernel@vger.kernel.org, kan.liang@intel.com, acme@kernel.org, namhyung@kernel.org Subject: Re: [PATCH 7/7] perf tools: Remove prot field in mmap param Message-ID: <20171113115234.GC3017@krava> References: <20171113013809.212417-1-wangnan0@huawei.com> <20171113013809.212417-8-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171113013809.212417-8-wangnan0@huawei.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 13 Nov 2017 11:52:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 13, 2017 at 01:38:09AM +0000, Wang Nan wrote: > After removing the concept of 'overwrite' in code level, now the > prot is determinated by write_backward. There's no need to pass > prot from perf_evlist__mmap_ex(). > > Signed-off-by: Wang Nan > --- > tools/perf/util/evlist.c | 17 ++++++----------- > tools/perf/util/mmap.c | 4 ++-- > tools/perf/util/mmap.h | 4 ++-- > 3 files changed, 10 insertions(+), 15 deletions(-) > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index 4948d3d..0d713e0 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -799,28 +799,23 @@ perf_evlist__should_poll(struct perf_evlist *evlist __maybe_unused, > } > > static int perf_evlist__mmap_per_evsel(struct perf_evlist *evlist, int idx, > - struct mmap_params *_mp, int cpu_idx, > + struct mmap_params *mp, int cpu_idx, > int thread, int *_output, int *_output_backward) > { > struct perf_evsel *evsel; > int revent; > int evlist_cpu = cpu_map__cpu(evlist->cpus, cpu_idx); > - struct mmap_params *mp; > > evlist__for_each_entry(evlist, evsel) { > struct perf_mmap *maps = evlist->mmap; > - struct mmap_params rdonly_mp; > int *output = _output; > int fd; > int cpu; > + int prot = PROT_READ; > > - mp = _mp; > if (evsel->attr.write_backward) { > output = _output_backward; > maps = evlist->backward_mmap; > - rdonly_mp = *_mp; > - rdonly_mp.prot &= ~PROT_WRITE; > - mp = &rdonly_mp; I dont think we need the first patch, you're reverting it in here jirka