All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
	sochin jiang <sochin.jiang@huawei.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test I/O limits with removable media
Date: Mon, 13 Nov 2017 15:49:48 +0000	[thread overview]
Message-ID: <20171113154948.GE27765@stefanha-x1.localdomain> (raw)
In-Reply-To: <071eb397118ed207c5a7f01d58766e415ee18d6a.1510339534.git.berto@igalia.com>

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

On Fri, Nov 10, 2017 at 08:54:48PM +0200, Alberto Garcia wrote:
> +        result = self.vm.qmp("blockdev-add", driver = "null-aio",
> +                             node_name = "cd0")

PEP8 says:

"Don't use spaces around the = sign when used to indicate a keyword
argument or a default parameter value."

https://www.python.org/dev/peps/pep-0008/#whitespace-in-expressions-and-statements

I fixed this while merging the patch.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  parent reply	other threads:[~2017-11-13 15:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-10 18:54 [Qemu-devel] [PATCH 0/3] Fix throttling crashes in BlockBackend with no BlockDriverState Alberto Garcia
2017-11-10 18:54 ` [Qemu-devel] [PATCH 1/3] block: Check for inserted BlockDriverState in blk_io_limits_disable() Alberto Garcia
2017-11-10 20:16   ` Max Reitz
2017-11-10 18:54 ` [Qemu-devel] [PATCH 2/3] block: Leave valid throttle timers when removing a BDS from a backend Alberto Garcia
2017-11-10 20:27   ` Max Reitz
2017-11-10 22:06   ` Alberto Garcia
2017-11-10 22:08     ` Max Reitz
2017-11-10 22:32       ` Alberto Garcia
2017-11-10 18:54 ` [Qemu-devel] [PATCH 3/3] qemu-iotests: Test I/O limits with removable media Alberto Garcia
2017-11-10 20:34   ` Max Reitz
2017-11-10 22:21   ` Max Reitz
2017-11-13 14:08     ` Alberto Garcia
2017-11-13 15:49   ` Stefan Hajnoczi [this message]
2017-11-13 15:57     ` Alberto Garcia
2017-11-13 15:49 ` [Qemu-devel] [PATCH 0/3] Fix throttling crashes in BlockBackend with no BlockDriverState Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171113154948.GE27765@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sochin.jiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.