From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 08/11] drm/i915: Pass crtc_state to ips toggle functions, v2 Date: Mon, 13 Nov 2017 19:18:27 +0200 Message-ID: <20171113171827.GS10981@intel.com> References: <20171110113503.16253-1-maarten.lankhorst@linux.intel.com> <20171110113503.16253-8-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id E5BB26E6D5 for ; Mon, 13 Nov 2017 17:18:32 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171110113503.16253-8-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMTAsIDIwMTcgYXQgMTI6MzU6MDBQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gQ2hhbmdlcyBzaW5jZSB2MToKPiAtIE9ubHkgcGFzcyBjcnRjX3N0YXRlLCBu b3QgY3J0Yy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5s YW5raG9yc3RAbGludXguaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9jb2xvci5jICAgfCAgNCArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYyB8IDI1ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHAuYyAgICAgIHwgIDYgKysrLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rydi5oICAgICB8ICA0ICsrLS0KPiAgNCBmaWxlcyBjaGFuZ2VkLCAyMSBp bnNlcnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nv bG9yLmMKPiBpbmRleCBiODMxNWJjYTg1MmIuLmFhNjZlOTUyYTk1ZCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfY29sb3IuYwo+IEBAIC0zNzAsNyArMzcwLDcgQEAgc3RhdGljIHZvaWQgaGFz d2VsbF9sb2FkX2x1dHMoc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICAJICov Cj4gIAlpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikgJiYgaW50ZWxfY3J0Y19zdGF0ZS0+aXBzX2Vu YWJsZWQgJiYKPiAgCSAgICAoaW50ZWxfY3J0Y19zdGF0ZS0+Z2FtbWFfbW9kZSA9PSBHQU1NQV9N T0RFX01PREVfU1BMSVQpKSB7Cj4gLQkJaHN3X2Rpc2FibGVfaXBzKGludGVsX2NydGMpOwo+ICsJ CWhzd19kaXNhYmxlX2lwcyhpbnRlbF9jcnRjX3N0YXRlKTsKPiAgCQlyZWVuYWJsZV9pcHMgPSB0 cnVlOwo+ICAJfQo+ICAKPiBAQCAtMzgwLDcgKzM4MCw3IEBAIHN0YXRpYyB2b2lkIGhhc3dlbGxf bG9hZF9sdXRzKHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiAgCWk5eHhfbG9h ZF9sdXRzKGNydGNfc3RhdGUpOwo+ICAKPiAgCWlmIChyZWVuYWJsZV9pcHMpCj4gLQkJaHN3X2Vu YWJsZV9pcHMoaW50ZWxfY3J0Yyk7Cj4gKwkJaHN3X2VuYWJsZV9pcHMoaW50ZWxfY3J0Y19zdGF0 ZSk7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIGJkd19sb2FkX2RlZ2FtbWFfbHV0KHN0cnVjdCBk cm1fY3J0Y19zdGF0ZSAqc3RhdGUpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ IGluZGV4IDFiM2YyNTgwMzhiMi4uNGFhMDJlMjc5ODVkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC00ODMyLDExICs0ODMyLDExIEBAIHN0YXRpYyB2b2lkIGly b25sYWtlX3BmaXRfZW5hYmxlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICAJfQo+ICB9Cj4g IAo+IC12b2lkIGhzd19lbmFibGVfaXBzKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICt2b2lk IGhzd19lbmFibGVfaXBzKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRl KQo+ICB7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YyA9IHRvX2ludGVsX2NydGMoY3J0Y19z dGF0ZS0+YmFzZS5jcnRjKTsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5iYXNl LmRldjsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2 KTsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlID0gY3J0Yy0+Y29uZmln Owo+ICAKPiAgCWlmICghY3J0Y19zdGF0ZS0+aXBzX2VuYWJsZWQgfHwKPiAgCSAgICAhKGNydGNf c3RhdGUtPmFjdGl2ZV9wbGFuZXMgJiBCSVQoUExBTkVfUFJJTUFSWSkpKQo+IEBAIC00ODczLDEy ICs0ODczLDEzIEBAIHZvaWQgaHN3X2VuYWJsZV9pcHMoc3RydWN0IGludGVsX2NydGMgKmNydGMp Cj4gIAl9Cj4gIH0KPiAgCj4gLXZvaWQgaHN3X2Rpc2FibGVfaXBzKHN0cnVjdCBpbnRlbF9jcnRj ICpjcnRjKQo+ICt2b2lkIGhzd19kaXNhYmxlX2lwcyhjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqY3J0Y19zdGF0ZSkKPiAgewo+ICsJc3RydWN0IGludGVsX2NydGMgKmNydGMgPSB0b19p bnRlbF9jcnRjKGNydGNfc3RhdGUtPmJhc2UuY3J0Yyk7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2ID0gY3J0Yy0+YmFzZS5kZXY7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYgPSB0b19pOTE1KGRldik7Cj4gIAo+IC0JaWYgKCFjcnRjLT5jb25maWctPmlwc19lbmFibGVk KQo+ICsJaWYgKCFjcnRjX3N0YXRlLT5pcHNfZW5hYmxlZCkKPiAgCQlyZXR1cm47Cj4gIAo+ICAJ YXNzZXJ0X3BsYW5lX2VuYWJsZWQoZGV2X3ByaXYsIGNydGMtPnBsYW5lKTsKPiBAQCAtNDkyNiw3 ICs0OTI3LDggQEAgc3RhdGljIHZvaWQgaW50ZWxfY3J0Y19kcG1zX292ZXJsYXlfZGlzYWJsZShz dHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YykKPiAgICogY29tcGxldGVseSBoaWRlIHRoZSBw cmltYXJ5IHBsYW5lLgo+ICAgKi8KPiAgc3RhdGljIHZvaWQKPiAtaW50ZWxfcG9zdF9lbmFibGVf cHJpbWFyeShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gK2ludGVsX3Bvc3RfZW5hYmxlX3ByaW1h cnkoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICsJCQkgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRj X3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9 IGNydGMtPmRldjsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5 MTUoZGV2KTsKPiBAQCAtNDkzOSw3ICs0OTQxLDcgQEAgaW50ZWxfcG9zdF9lbmFibGVfcHJpbWFy eShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gIAkgKiB3aGVuIGdvaW5nIGZyb20gcHJpbWFyeSBv bmx5IHRvIHNwcml0ZSBvbmx5IGFuZCB2aWNlCj4gIAkgKiB2ZXJzYS4KPiAgCSAqLwo+IC0JaHN3 X2VuYWJsZV9pcHMoaW50ZWxfY3J0Yyk7Cj4gKwloc3dfZW5hYmxlX2lwcyhuZXdfY3J0Y19zdGF0 ZSk7Cj4gIAo+ICAJLyoKPiAgCSAqIEdlbjIgcmVwb3J0cyBwaXBlIHVuZGVycnVucyB3aGVuZXZl ciBhbGwgcGxhbmVzIGFyZSBkaXNhYmxlZC4KPiBAQCAtNDk1OCw3ICs0OTYwLDggQEAgaW50ZWxf cG9zdF9lbmFibGVfcHJpbWFyeShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gIAo+ICAvKiBGSVhN RSBtb3ZlIGFsbCB0aGlzIHRvIHByZV9wbGFuZV91cGRhdGUoKSB3aXRoIHByb3BlciBzdGF0ZSB0 cmFja2luZyAqLwo+ICBzdGF0aWMgdm9pZAo+IC1pbnRlbF9wcmVfZGlzYWJsZV9wcmltYXJ5KHN0 cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAraW50ZWxfcHJlX2Rpc2FibGVfcHJpbWFyeShzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMsCj4gKwkJCSAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9s ZF9jcnRjX3N0YXRlKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+ZGV2 Owo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ IEBAIC00OTgwLDcgKzQ5ODMsNyBAQCBpbnRlbF9wcmVfZGlzYWJsZV9wcmltYXJ5KHN0cnVjdCBk cm1fY3J0YyAqY3J0YykKPiAgCSAqIHdoZW4gZ29pbmcgZnJvbSBwcmltYXJ5IG9ubHkgdG8gc3By aXRlIG9ubHkgYW5kIHZpY2UKPiAgCSAqIHZlcnNhLgo+ICAJICovCj4gLQloc3dfZGlzYWJsZV9p cHMoaW50ZWxfY3J0Yyk7Cj4gKwloc3dfZGlzYWJsZV9pcHMob2xkX2NydGNfc3RhdGUpOwo+ICB9 Cj4gIAo+ICAvKiBGSVhNRSBnZXQgcmlkIG9mIHRoaXMgYW5kIHVzZSBwcmVfcGxhbmVfdXBkYXRl ICovCj4gQEAgLTQ5OTIsNyArNDk5NSw3IEBAIGludGVsX3ByZV9kaXNhYmxlX3ByaW1hcnlfbm9h dG9taWMoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ICAJc3RydWN0IGludGVsX2NydGMgKmludGVs X2NydGMgPSB0b19pbnRlbF9jcnRjKGNydGMpOwo+ICAJaW50IHBpcGUgPSBpbnRlbF9jcnRjLT5w aXBlOwo+ICAKPiAtCWludGVsX3ByZV9kaXNhYmxlX3ByaW1hcnkoY3J0Yyk7Cj4gKwlpbnRlbF9w cmVfZGlzYWJsZV9wcmltYXJ5KGNydGMsIHRvX2ludGVsX2NydGNfc3RhdGUoY3J0Yy0+c3RhdGUp KTsKPiAgCj4gIAkvKgo+ICAJICogVmJsYW5rIHRpbWUgdXBkYXRlcyBmcm9tIHRoZSBzaGFkb3cg dG8gbGl2ZSBwbGFuZSBjb250cm9sIHJlZ2lzdGVyCj4gQEAgLTUwMzYsNyArNTAzOSw3IEBAIHN0 YXRpYyB2b2lkIGludGVsX3Bvc3RfcGxhbmVfdXBkYXRlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICpvbGRfY3J0Y19zdGF0ZSkKPiAgCQlpZiAocHJpbWFyeV9zdGF0ZS0+YmFzZS52aXNpYmxlICYm Cj4gIAkJICAgIChuZWVkc19tb2Rlc2V0KCZwaXBlX2NvbmZpZy0+YmFzZSkgfHwKPiAgCQkgICAg ICFvbGRfcHJpbWFyeV9zdGF0ZS0+YmFzZS52aXNpYmxlKSkKPiAtCQkJaW50ZWxfcG9zdF9lbmFi bGVfcHJpbWFyeSgmY3J0Yy0+YmFzZSk7Cj4gKwkJCWludGVsX3Bvc3RfZW5hYmxlX3ByaW1hcnko JmNydGMtPmJhc2UsIHBpcGVfY29uZmlnKTsKPiAgCX0KPiAgfQo+ICAKPiBAQCAtNTA2NSw3ICs1 MDY4LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfcHJlX3BsYW5lX3VwZGF0ZShzdHJ1Y3QgaW50ZWxf Y3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUsCj4gIAo+ICAJCWlmIChvbGRfcHJpbWFyeV9zdGF0 ZS0+YmFzZS52aXNpYmxlICYmCj4gIAkJICAgIChtb2Rlc2V0IHx8ICFwcmltYXJ5X3N0YXRlLT5i YXNlLnZpc2libGUpKQo+IC0JCQlpbnRlbF9wcmVfZGlzYWJsZV9wcmltYXJ5KCZjcnRjLT5iYXNl KTsKPiArCQkJaW50ZWxfcHJlX2Rpc2FibGVfcHJpbWFyeSgmY3J0Yy0+YmFzZSwgb2xkX2NydGNf c3RhdGUpOwo+ICAJfQo+ICAKPiAgCS8qCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gaW5kZXgg YWJlZjAzOTJhYmI5Li44YjU3ZTRjMDY0ZTEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMK PiBAQCAtMzk0OSw3ICszOTQ5LDcgQEAgc3RhdGljIGludCBpbnRlbF9kcF9zaW5rX2NyY19zdG9w KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gIAo+ICAgb3V0Ogo+ICAJaWYgKGRpc2FibGVf d2EpCj4gLQkJaHN3X2VuYWJsZV9pcHMoaW50ZWxfY3J0Yyk7Cj4gKwkJaHN3X2VuYWJsZV9pcHMo Y3J0Y19zdGF0ZSk7Cj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+IEBAIC0zOTc3LDExICszOTc3 LDExIEBAIHN0YXRpYyBpbnQgaW50ZWxfZHBfc2lua19jcmNfc3RhcnQoc3RydWN0IGludGVsX2Rw ICppbnRlbF9kcCwKPiAgCQkJcmV0dXJuIHJldDsKPiAgCX0KPiAgCj4gLQloc3dfZGlzYWJsZV9p cHMoaW50ZWxfY3J0Yyk7Cj4gKwloc3dfZGlzYWJsZV9pcHMoY3J0Y19zdGF0ZSk7Cj4gIAo+ICAJ aWYgKGRybV9kcF9kcGNkX3dyaXRlYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LLAo+ICAJ CQkgICAgICAgYnVmIHwgRFBfVEVTVF9TSU5LX1NUQVJUKSA8IDApIHsKPiAtCQloc3dfZW5hYmxl X2lwcyhpbnRlbF9jcnRjKTsKPiArCQloc3dfZW5hYmxlX2lwcyhjcnRjX3N0YXRlKTsKPiAgCQly ZXR1cm4gLUVJTzsKPiAgCX0KPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCA2 YWJlNTIxNjE0MzcuLmI1ZGI2YmJlZjdiOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o Cj4gQEAgLTE0OTAsOCArMTQ5MCw4IEBAIGJvb2wgYnh0X2ZpbmRfYmVzdF9kcGxsKHN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLCBpbnQgdGFyZ2V0X2Nsb2NrLAo+ICBpbnQgY2h2 X2NhbGNfZHBsbF9wYXJhbXMoaW50IHJlZmNsaywgc3RydWN0IGRwbGwgKnBsbF9jbG9jayk7Cj4g IAo+ICBib29sIGludGVsX2NydGNfYWN0aXZlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKTsKPiAt dm9pZCBoc3dfZW5hYmxlX2lwcyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0Yyk7Cj4gLXZvaWQgaHN3 X2Rpc2FibGVfaXBzKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKTsKPiArdm9pZCBoc3dfZW5hYmxl X2lwcyhjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSk7Cj4gK3ZvaWQg aHN3X2Rpc2FibGVfaXBzKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRl KTsKPiAgZW51bSBpbnRlbF9kaXNwbGF5X3Bvd2VyX2RvbWFpbiBpbnRlbF9wb3J0X3RvX3Bvd2Vy X2RvbWFpbihlbnVtIHBvcnQgcG9ydCk7Cj4gIHZvaWQgaW50ZWxfbW9kZV9mcm9tX3BpcGVfY29u ZmlnKHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlLAo+ICAJCQkJIHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpwaXBlX2NvbmZpZyk7Cj4gLS0gCj4gMi4xNS4wCj4gCj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBs aXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOk bMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK