From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754416AbdKMScf (ORCPT ); Mon, 13 Nov 2017 13:32:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:54344 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753948AbdKMScb (ORCPT ); Mon, 13 Nov 2017 13:32:31 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A733A21910 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 13 Nov 2017 15:32:28 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: linux-kernel@vger.kernel.org, kan.liang@intel.com, jolsa@redhat.com, namhyung@kernel.org Subject: Re: [PATCH 5/7] perf tests: Set evlist of test__task_exit() to !overwrite Message-ID: <20171113183228.GE8836@kernel.org> References: <20171113013809.212417-1-wangnan0@huawei.com> <20171113013809.212417-6-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171113013809.212417-6-wangnan0@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Nov 13, 2017 at 01:38:07AM +0000, Wang Nan escreveu: > Changing ringbuffer to !overwrite in this task is harmless because > this test uses a very low frequency (1) and using a very simple > program (true). There should have only 3 events in the whole test. > Overwriting is impossible to happen. applied > Signed-off-by: Wang Nan > --- > tools/perf/tests/task-exit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/tests/task-exit.c b/tools/perf/tests/task-exit.c > index f0881d0..4fb6609 100644 > --- a/tools/perf/tests/task-exit.c > +++ b/tools/perf/tests/task-exit.c > @@ -96,7 +96,7 @@ int test__task_exit(struct test *test __maybe_unused, int subtest __maybe_unused > goto out_delete_evlist; > } > > - if (perf_evlist__mmap(evlist, 128, true) < 0) { > + if (perf_evlist__mmap(evlist, 128, false) < 0) { > pr_debug("failed to mmap events: %d (%s)\n", errno, > str_error_r(errno, sbuf, sizeof(sbuf))); > goto out_delete_evlist; > -- > 2.10.1