From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755352AbdKMUOq (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Nov 2017 15:14:46 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48544 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753414AbdKMUOm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Nov 2017 15:14:42 -0500
Date: Mon, 13 Nov 2017 21:14:38 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, David Ahern <dsahern@gmail.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 16/35] perf annotate: Add samples into struct
 annotation_line
Message-ID: <20171113201438.GB26900@krava>
References: <20171011150158.11895-1-jolsa@kernel.org>
 <20171011150158.11895-17-jolsa@kernel.org>
 <c7ea9339-804f-c56a-fc4c-960036ccfb86@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c7ea9339-804f-c56a-fc4c-960036ccfb86@linux.vnet.ibm.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 13 Nov 2017 20:14:42 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 13, 2017 at 09:16:20PM +0530, Ravi Bangoria wrote:
> Hi Jiri,
> 
> This patch seems to be causing segfault with "perf top --stdio".
> 
> Steps to reproduce:
> 1. start "perf top --stdio" in one terminal
> 2. run some simple workload in another terminal, let it get finished.
> 3. annotate function from previous workload in perf top (press 'a' followed
> by 's')
> 
> Perf will crash with:
> 
>   perf: Segmentation fault
>   Obtained 8 stack frames.
>   ./perf(sighandler_dump_stack+0x3e) [0x4f1b6e]
>   /lib64/libc.so.6(+0x36a7f) [0x7ff3aa7e4a7f]
>   ./perf() [0x4a27fd]
>   ./perf(symbol__annotate+0x199) [0x4a4439]
>   ./perf() [0x44e32d]
>   ./perf() [0x44f098]
>   /lib64/libpthread.so.0(+0x736c) [0x7ff3acee836c]
>   /lib64/libc.so.6(clone+0x3e) [0x7ff3aa8bee1e]
> 
> Can you please check.

hum, I'm getting following crash after resizing the terminal window:

perf: Floating point exception
Obtained 8 stack frames.
./perf(dump_stack+0x2e) [0x510c89]
./perf(sighandler_dump_stack+0x2e) [0x510d69]
/lib64/libc.so.6(+0x36a80) [0x7f9419588a80]
./perf(perf_top__header_snprintf+0x208) [0x4f42c1]
./perf() [0x453c09]
./perf() [0x454ddb]
/lib64/libpthread.so.0(+0x736d) [0x7f941bc8c36d]
/lib64/libc.so.6(clone+0x3f) [0x7f9419662e1f]
Floating point exception (core dumped)

working on fix

jirka