From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ewelina Musial Subject: Re: [PATCH v3 1/4] drm/i915/perf: replace .reg accesses with i915_mmio_reg_offset Date: Tue, 14 Nov 2017 08:26:45 +0100 Message-ID: <20171114072645.GA17613@emusial-desk.ger.corp.intel.com> References: <20171113233455.12085-1-lionel.g.landwerlin@intel.com> <20171113233455.12085-2-lionel.g.landwerlin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id BF6F76E830 for ; Tue, 14 Nov 2017 07:23:24 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171113233455.12085-2-lionel.g.landwerlin@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lionel Landwerlin Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBOb3YgMTMsIDIwMTcgYXQgMTE6MzQ6NTJQTSArMDAwMCwgTGlvbmVsIExhbmR3ZXJs aW4gd3JvdGU6Cj4gVGhpcyByZXBsYWNlcyBhY2Nlc3NlcyB0byB0aGUgcmVnIGZpZWxkIG9mIHRo ZSBpOTE1X3JlZ190IHN0cnVjdHVyZQo+IHdpdGggdGhlIGk5MTVfbW1pb19yZWdfb2Zmc2V0KCkg aW5saW5lIGZ1bmN0aW9uLgo+IAo+IFN1Z2dlc3RlZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0Bj aHJpcy13aWxzb24uY28udWs+Cj4gU2lnbmVkLW9mZi1ieTogTGlvbmVsIExhbmR3ZXJsaW4gPGxp b25lbC5nLmxhbmR3ZXJsaW5AaW50ZWwuY29tPgpSZXZpZXdlZC1ieTogRXdlbGluYSBNdXNpYWwg PGV3ZWxpbmEubXVzaWFsQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9wZXJmLmMgfCAzOSArKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0K PiAgMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BlcmYuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfcGVyZi5jCj4gaW5kZXggMDBiZTAxNWUwMWRmLi4wZjQ4ZTY2NjA5 OGQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wZXJmLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BlcmYuYwo+IEBAIC0zMDA3LDcgKzMwMDcsNyBA QCBzdGF0aWMgYm9vbCBnZW44X2lzX3ZhbGlkX2ZsZXhfYWRkcihzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsIHUzMiBhZGRyKQo+ICAJaW50IGk7Cj4gIAo+ICAJZm9yIChpID0gMDsg aSA8IEFSUkFZX1NJWkUoZmxleF9ldV9yZWdzKTsgaSsrKSB7Cj4gLQkJaWYgKGZsZXhfZXVfcmVn c1tpXS5yZWcgPT0gYWRkcikKPiArCQlpZiAoaTkxNV9tbWlvX3JlZ19vZmZzZXQoZmxleF9ldV9y ZWdzW2ldKSA9PSBhZGRyKQo+ICAJCQlyZXR1cm4gdHJ1ZTsKPiAgCX0KPiAgCXJldHVybiBmYWxz ZTsKPiBAQCAtMzAxNSwzOCArMzAxNSw0NyBAQCBzdGF0aWMgYm9vbCBnZW44X2lzX3ZhbGlkX2Zs ZXhfYWRkcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBhZGRyKQo+ICAK PiAgc3RhdGljIGJvb2wgZ2VuN19pc192YWxpZF9iX2NvdW50ZXJfYWRkcihzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBhZGRyKQo+ICB7Cj4gLQlyZXR1cm4gKGFkZHIgPj0g T0FTVEFSVFRSSUcxLnJlZyAmJiBhZGRyIDw9IE9BU1RBUlRUUklHOC5yZWcpIHx8Cj4gLQkJKGFk ZHIgPj0gT0FSRVBPUlRUUklHMS5yZWcgJiYgYWRkciA8PSBPQVJFUE9SVFRSSUc4LnJlZykgfHwK PiAtCQkoYWRkciA+PSBPQUNFQzBfMC5yZWcgJiYgYWRkciA8PSBPQUNFQzdfMS5yZWcpOwo+ICsJ cmV0dXJuIChhZGRyID49IGk5MTVfbW1pb19yZWdfb2Zmc2V0KE9BU1RBUlRUUklHMSkgJiYKPiAr CQlhZGRyIDw9IGk5MTVfbW1pb19yZWdfb2Zmc2V0KE9BU1RBUlRUUklHOCkpIHx8Cj4gKwkJKGFk ZHIgPj0gaTkxNV9tbWlvX3JlZ19vZmZzZXQoT0FSRVBPUlRUUklHMSkgJiYKPiArCQkgYWRkciA8 PSBpOTE1X21taW9fcmVnX29mZnNldChPQVJFUE9SVFRSSUc4KSkgfHwKPiArCQkoYWRkciA+PSBp OTE1X21taW9fcmVnX29mZnNldChPQUNFQzBfMCkgJiYKPiArCQkgYWRkciA8PSBpOTE1X21taW9f cmVnX29mZnNldChPQUNFQzdfMSkpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgYm9vbCBnZW43X2lzX3Zh bGlkX211eF9hZGRyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTMyIGFkZHIp Cj4gIHsKPiAtCXJldHVybiBhZGRyID09IEhBTEZfU0xJQ0VfQ0hJQ0tFTjIucmVnIHx8Cj4gLQkJ KGFkZHIgPj0gTUlDUk9fQlAwXzAucmVnICYmIGFkZHIgPD0gTk9BX1dSSVRFLnJlZykgfHwKPiAt CQkoYWRkciA+PSBPQV9QRVJGQ05UMV9MTy5yZWcgJiYgYWRkciA8PSBPQV9QRVJGQ05UMl9ISS5y ZWcpIHx8Cj4gLQkJKGFkZHIgPj0gT0FfUEVSRk1BVFJJWF9MTy5yZWcgJiYgYWRkciA8PSBPQV9Q RVJGTUFUUklYX0hJLnJlZyk7Cj4gKwlyZXR1cm4gYWRkciA9PSBpOTE1X21taW9fcmVnX29mZnNl dChIQUxGX1NMSUNFX0NISUNLRU4yKSB8fAo+ICsJCShhZGRyID49IGk5MTVfbW1pb19yZWdfb2Zm c2V0KE1JQ1JPX0JQMF8wKSAmJgo+ICsJCSBhZGRyIDw9IGk5MTVfbW1pb19yZWdfb2Zmc2V0KE5P QV9XUklURSkpIHx8Cj4gKwkJKGFkZHIgPj0gaTkxNV9tbWlvX3JlZ19vZmZzZXQoT0FfUEVSRkNO VDFfTE8pICYmCj4gKwkJIGFkZHIgPD0gaTkxNV9tbWlvX3JlZ19vZmZzZXQoT0FfUEVSRkNOVDJf SEkpKSB8fAo+ICsJCShhZGRyID49IGk5MTVfbW1pb19yZWdfb2Zmc2V0KE9BX1BFUkZNQVRSSVhf TE8pICYmCj4gKwkJIGFkZHIgPD0gaTkxNV9tbWlvX3JlZ19vZmZzZXQoT0FfUEVSRk1BVFJJWF9I SSkpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgYm9vbCBnZW44X2lzX3ZhbGlkX211eF9hZGRyKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTMyIGFkZHIpCj4gIHsKPiAgCXJldHVybiBn ZW43X2lzX3ZhbGlkX211eF9hZGRyKGRldl9wcml2LCBhZGRyKSB8fAo+IC0JCWFkZHIgPT0gV0FJ VF9GT1JfUkM2X0VYSVQucmVnIHx8Cj4gLQkJKGFkZHIgPj0gUlBNX0NPTkZJRzAucmVnICYmIGFk ZHIgPD0gTk9BX0NPTkZJRyg4KS5yZWcpOwo+ICsJCWFkZHIgPT0gaTkxNV9tbWlvX3JlZ19vZmZz ZXQoV0FJVF9GT1JfUkM2X0VYSVQpIHx8Cj4gKwkJKGFkZHIgPj0gaTkxNV9tbWlvX3JlZ19vZmZz ZXQoUlBNX0NPTkZJRzApICYmCj4gKwkJIGFkZHIgPD0gaTkxNV9tbWlvX3JlZ19vZmZzZXQoTk9B X0NPTkZJRyg4KSkpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgYm9vbCBnZW4xMF9pc192YWxpZF9tdXhf YWRkcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBhZGRyKQo+ICB7Cj4g IAlyZXR1cm4gZ2VuOF9pc192YWxpZF9tdXhfYWRkcihkZXZfcHJpdiwgYWRkcikgfHwKPiAtCQko YWRkciA+PSBPQV9QRVJGQ05UM19MTy5yZWcgJiYgYWRkciA8PSBPQV9QRVJGQ05UNF9ISS5yZWcp Owo+ICsJCShhZGRyID49IGk5MTVfbW1pb19yZWdfb2Zmc2V0KE9BX1BFUkZDTlQzX0xPKSAmJgo+ ICsJCSBhZGRyIDw9IGk5MTVfbW1pb19yZWdfb2Zmc2V0KE9BX1BFUkZDTlQ0X0hJKSk7Cj4gIH0K PiAgCj4gIHN0YXRpYyBib29sIGhzd19pc192YWxpZF9tdXhfYWRkcihzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBhZGRyKQo+ICB7Cj4gIAlyZXR1cm4gZ2VuN19pc192YWxp ZF9tdXhfYWRkcihkZXZfcHJpdiwgYWRkcikgfHwKPiAgCQkoYWRkciA+PSAweDI1MTAwICYmIGFk ZHIgPD0gMHgyRkY5MCkgfHwKPiAtCQkoYWRkciA+PSBIU1dfTUJWSUQyX05PQTAucmVnICYmIGFk ZHIgPD0gSFNXX01CVklEMl9OT0E5LnJlZykgfHwKPiAtCQlhZGRyID09IEhTV19NQlZJRDJfTUlT UjAucmVnOwo+ICsJCShhZGRyID49IGk5MTVfbW1pb19yZWdfb2Zmc2V0KEhTV19NQlZJRDJfTk9B MCkgJiYKPiArCQkgYWRkciA8PSBpOTE1X21taW9fcmVnX29mZnNldChIU1dfTUJWSUQyX05PQTkp KSB8fAo+ICsJCWFkZHIgPT0gaTkxNV9tbWlvX3JlZ19vZmZzZXQoSFNXX01CVklEMl9NSVNSMCk7 Cj4gIH0KPiAgCj4gIHN0YXRpYyBib29sIGNodl9pc192YWxpZF9tdXhfYWRkcihzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBhZGRyKQo+IEBAIC0zMDYxLDE0ICszMDcwLDE0 IEBAIHN0YXRpYyB1aW50MzJfdCBtYXNrX3JlZ192YWx1ZSh1MzIgcmVnLCB1MzIgdmFsKQo+ICAJ ICogV2FEaXNhYmxlU1RVbml0UG93ZXJPcHRpbWl6YXRpb24gd29ya2Fyb3VuZC4gTWFrZSBzdXJl IHRoZSB2YWx1ZQo+ICAJICogcHJvZ3JhbW1lZCBieSB1c2Vyc3BhY2UgZG9lc24ndCBjaGFuZ2Ug dGhpcy4KPiAgCSAqLwo+IC0JaWYgKEhBTEZfU0xJQ0VfQ0hJQ0tFTjIucmVnID09IHJlZykKPiAr CWlmIChpOTE1X21taW9fcmVnX29mZnNldChIQUxGX1NMSUNFX0NISUNLRU4yKSA9PSByZWcpCj4g IAkJdmFsID0gdmFsICYgfl9NQVNLRURfQklUX0VOQUJMRShHRU44X1NUX1BPX0RJU0FCTEUpOwo+ ICAKPiAgCS8qIFdBSVRfRk9SX1JDNl9FWElUIGhhcyBvbmx5IG9uZSBiaXQgZnVsbGZpbGxpbmcg dGhlIGZ1bmN0aW9uCj4gIAkgKiBpbmRpY2F0ZWQgYnkgaXRzIG5hbWUgYW5kIGEgYnVuY2ggb2Yg c2VsZWN0aW9uIGZpZWxkcyB1c2VkIGJ5IE9BCj4gIAkgKiBjb25maWdzLgo+ICAJICovCj4gLQlp ZiAoV0FJVF9GT1JfUkM2X0VYSVQucmVnID09IHJlZykKPiArCWlmIChpOTE1X21taW9fcmVnX29m ZnNldChXQUlUX0ZPUl9SQzZfRVhJVCkgPT0gcmVnKQo+ICAJCXZhbCA9IHZhbCAmIH5fTUFTS0VE X0JJVF9FTkFCTEUoSFNXX1dBSVRfRk9SX1JDNl9FWElUX0VOQUJMRSk7Cj4gIAo+ICAJcmV0dXJu IHZhbDsKPiAtLSAKPiAyLjE1LjAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==