From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754777AbdKNMJc (ORCPT ); Tue, 14 Nov 2017 07:09:32 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:56418 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704AbdKNMJZ (ORCPT ); Tue, 14 Nov 2017 07:09:25 -0500 Date: Tue, 14 Nov 2017 13:09:30 +0100 From: Greg Kroah-Hartman To: Ulf Hansson Cc: "Tobin C. Harding" , kernelnewbies@kernelnewbies.org, "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: git pull Message-ID: <20171114120930.GA28122@kroah.com> References: <20171113231155.GA26779@eros> <20171114110500.GA21175@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 14, 2017 at 01:00:14PM +0100, Ulf Hansson wrote: > [...] > > > > > An example pull request of mine might look like: > > Char/Misc patches for 4.15-rc1 > > > > Here is the big char/misc patch set for the 4.15-rc1 merge > > window. Contained in here is the normal set of new functions > > added to all of these crazy drivers, as well as the following > > brand new subsystems: > > - time_travel_controller: Finally a set of drivers for > > the latest time travel bus architecture that provides > > i/o to the CPU before it asked for it, allowing > > uninterrupted processing > > - relativity_shifters: due to the affect that the > > time_travel_controllers have on the overall system, > > there was a need for a new set of relativity shifter > > drivers to accommodate the newly formed black holes > > that would threaten to suck CPUs into them. This > > subsystem handles this in a way to successfully > > neutralize the problems. There is a Kconfig option to > > force these to be enabled when needed, so problems > > should not occur. > > > > All of these patches have been successfully tested in the latest > > linux-next releases, and the original problems that it found > > have all been resolved (apologies to anyone living near Canberra > > for the lack of the Kconfig options in the earlier versions of > > the linux-next tree creations.) > > > > Signed-off-by: Your-name-here > > > > > > The tag message format is just like a git commit id. One line at the > > top for a "summary subject" and be sure to sign-off at the bottom. > > I don't add my s-o-b to signed tags for pull requests, but perhaps I should. > > However, I think most maintainers don't use it, and neither does it > seems like Linus is preserving the tag when he does the pull. The text of the tag is in the merge commit, but you are right, the signed-off-by doesn't seem to be in the merge commit, I guess Linus's workflow removes them. I know I keep them in there if present for pull requests that people send to me. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Tue, 14 Nov 2017 13:09:30 +0100 Subject: git pull In-Reply-To: References: <20171113231155.GA26779@eros> <20171114110500.GA21175@kroah.com> Message-ID: <20171114120930.GA28122@kroah.com> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org On Tue, Nov 14, 2017 at 01:00:14PM +0100, Ulf Hansson wrote: > [...] > > > > > An example pull request of mine might look like: > > Char/Misc patches for 4.15-rc1 > > > > Here is the big char/misc patch set for the 4.15-rc1 merge > > window. Contained in here is the normal set of new functions > > added to all of these crazy drivers, as well as the following > > brand new subsystems: > > - time_travel_controller: Finally a set of drivers for > > the latest time travel bus architecture that provides > > i/o to the CPU before it asked for it, allowing > > uninterrupted processing > > - relativity_shifters: due to the affect that the > > time_travel_controllers have on the overall system, > > there was a need for a new set of relativity shifter > > drivers to accommodate the newly formed black holes > > that would threaten to suck CPUs into them. This > > subsystem handles this in a way to successfully > > neutralize the problems. There is a Kconfig option to > > force these to be enabled when needed, so problems > > should not occur. > > > > All of these patches have been successfully tested in the latest > > linux-next releases, and the original problems that it found > > have all been resolved (apologies to anyone living near Canberra > > for the lack of the Kconfig options in the earlier versions of > > the linux-next tree creations.) > > > > Signed-off-by: Your-name-here > > > > > > The tag message format is just like a git commit id. One line at the > > top for a "summary subject" and be sure to sign-off at the bottom. > > I don't add my s-o-b to signed tags for pull requests, but perhaps I should. > > However, I think most maintainers don't use it, and neither does it > seems like Linus is preserving the tag when he does the pull. The text of the tag is in the merge commit, but you are right, the signed-off-by doesn't seem to be in the merge commit, I guess Linus's workflow removes them. I know I keep them in there if present for pull requests that people send to me. thanks, greg k-h